[HOLD - #288] Disable chat notifications on WwwDot AND legacy mobile app

[quinthar]

As we move from WwwDot to ChatDot, it's confusing to get notifications twice. Let's disable notifications on web and mobile for the old codebase on chat reports. So you will still get notifications on the old codebase for non-chat reports (which aren't supported by ChatDot), and then you will get notifications for chat reports on ChatDot.

[quinthar]

Can we close this?

[quinthar]

Does this also disable mobile push notifications to the old Expensify app for chats?

[chiragsalian]

Can't close this out just yet. I've written the code for web and pushed it first. It was merged yesterday but since its www it hasn't even gone to staging yet. It should be live Tuesday (unless we want to CP it earlier).

As for mobile, i haven't written that part just yet. I was discussing it with @AndrewGable and he initially suggested that we'd have to look into creating a new Airship API key so that we can handle a new notification differently and treat them as separate apps. Because on mobile atm if i send a new notification the app will still show it but do nothing if you click it. Anyway figuring out that part.

[chiragsalian]

Okay so it seems that we already have an issue to add a new airship - #288.

The PR is currently in WIP and once its finished we can add a new push event like "reportChatComment" for which,

• chat handles it appropriately by updating the specified chat.
• web ignores this new event.
• Older mobile Expensify code would be unaware of this airship to show a notification.

This GH is effectively on HOLD till #288 is done.