[HOLD for payment 2024-03-14] HIGH: Onyx updates from push notifications can get applied out of order

[arosiclair]

Note: Waiting for #34082 to build the troubleshooting tools

• Coming from this slack convo cc @iwiznia

Problem

When a user receives a report comment, we send them a push notification for it. The notification payload contains Onyx updates for the report and the new report action. We apply those onyx updates here and call ReconnectApp in the background using backgroundRefresh.

There is a chance this update gets applied out of order eg:

1. User A sends a message and edits it quickly
2. User B applies updates for the new message and edit from Pusher
3. User B receives a delayed push notification for the message and applies the update for the original un-edited message

Why is this important?

If this happens, the report and report action data will stay out of date until the next updates are received

Solution

Start including lastUpdateID and previousUpdateID in the notification payload and use those to apply the update like we do for reliable updates here so those updates always get applied in order.

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~018a77e81664929acf
• Upwork Job ID: 1735753015692898304
• Last Price Increase: 2023-12-15

Issue Owner

Current Issue Owner: @JmillsExpensify

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~018a77e81664929acf

[melvin-bot]

Triggered auto assignment to @JmillsExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to Contributor Plus for review of internal employee PR - @allroundexperts (Internal)

[melvin-bot]

@JmillsExpensify, @arosiclair, @allroundexperts Whoops! This issue is 2 days overdue. Let's get this updated quick!

[arosiclair]

No progress on this yet. I'm heads down on Notification Polish and then OOO for a couple days. I should be able to get to this next week.