[HOLD for payment 2024-02-14] [$500] Request Money - Previous currency is shown selected if edit Amount&Currency in Request Money

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.17-1
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

1. Login to ND Expensify
2. Tap FAB button
3. Tap Request money
4. Select Manual tab
5. Select a currency and enter any amount
6. Tap Next
7. Select an attandee
8. When in final review page, click on Amount field to edit
9. Click on Currency and change to another one
10. Again click on Currency and verify if new selected currency is shown

Expected Result:

Last selected currency should be shown while editing Request Money

Actual Result:

Previous currency is shown selected if user changes it while editing Request Money

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6326315_1703614106567.2023-12-26_20-14-43.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0137f820b6bde4b24a
• Upwork Job ID: 1739718074911305728
• Last Price Increase: 2023-12-26
• Automatic offers:
• hoangzinh | Reviewer | 28076604
• shubham1206agra | Contributor | 28076605

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0137f820b6bde4b24a

[melvin-bot]

Triggered auto assignment to @bfitzexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @hoangzinh (External)

[FitseTLT]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Request Money - Previous currency is shown selected if edit Amount&Currency in Request Money

What is the root cause of that problem?

We are not updating draft transaction when the pageindex is confirm here

App/src/pages/iou/request/step/IOURequestStepCurrency.js

Lines 85 to 87 in 595bf40

	if (pageIndex !== 'confirm') {
	IOU.setMoneyRequestCurrency_temporaryForRefactor(transactionID, option.currencyCode);
	}

from this pr to avoid the saving of the currency on transaction when the user just navigates back after changing the currency without pressing save.

What changes do you think we should make in order to solve the problem?

Use the same mechnism we used in IOURequestStepAmount and give the current currency in the route by naviagting with currency param here

App/src/pages/iou/request/step/IOURequestStepAmount.js

Lines 66 to 68 in 595bf40

	const navigateToCurrencySelectionPage = () => {
	Navigation.navigate(ROUTES.MONEY_REQUEST_STEP_CURRENCY.getRoute(iouType, transactionID, reportID, backTo ? 'confirm' : '', Navigation.getActiveRouteWithoutParams()));
	};

to

const navigateToCurrencySelectionPage = () => {
        Navigation.navigate(
            `${ROUTES.MONEY_REQUEST_STEP_CURRENCY.getRoute(iouType, transactionID, reportID, backTo ? 'confirm' : '', Navigation.getActiveRouteWithoutParams())}&currency=${currency}`,
        );
    };

Inside IOURequestStepCurrency

    const currency = pageIndex === 'confirm' ? currencyFromRoute : transactionCurrency;

What alternative solutions did you explore? (Optional)

[shubham1206agra]

Proposal

Please re-state the problem that we are trying to solve in this issue

Request Money - Previous currency is shown selected if edit Amount&Currency in Request Money

What is the root cause of that problem?

This PR #32826 prohibits the change in currency in transaction draft when on confirm page.

What changes do you think we should make in order to solve the problem?

Add new property originalCurrency, and use it to restore the currency on pressing on back button only. And let IOU.setMoneyRequestCurrency_temporaryForRefactor(transactionID, option.currencyCode); run unconditionally

Explaination

This works by creating a field inside transaction draft onyx structure named original currency

/**
 * @param {String} transactionID
 * @param {String} originalCurrency
 */
function setMoneyRequestOriginalCurrency_temporaryForRefactor(transactionID, originalCurrency) {
    Onyx.merge(`${ONYXKEYS.COLLECTION.TRANSACTION_DRAFT}${transactionID}`, {originalCurrency});
}

And use this method on mount method of IOURequestStepAmount component, since this is the only place from where we can change currency.

And then restore the currency if save method was never hit on this step during unmount method

What alternative solutions did you explore? (Optional)

[namhihi237]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Currency is not updated when edit

What is the root cause of that problem?

Currently, we get currency from the draft transaction, When we select from the list we don't save anywhere when slect row until we save on the IOURequestStepAmount screen.

What changes do you think we should make in order to solve the problem?

We should pass the query current currency from IOURequestStepAmount when open IOURequestStepCurrency to show the currency selected before. We will priority show currency from url first and then the draft

What alternative solutions did you explore? (Optional)

N/A

[dukenv0307]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Previous currency is shown selected if user changes it while editing Request Money

What is the root cause of that problem?

The selected currency is displayed as the currency which we stored in transaction. When we select a currency and the pageIndex is confirm we don't store this in transaction. So when we go to this page again, the selected currency is still the previous currency

App/src/pages/iou/request/step/IOURequestStepCurrency.js

Line 85 in 6365aeb

if (pageIndex !== 'confirm') {

What changes do you think we should make in order to solve the problem?

We don't store this to transaction to avoid the case the user just goes back to confirm page without saving. We can remove this condition to always store to selected currency in transaction

Keyboard.dismiss();
IOU.setMoneyRequestCurrency_temporaryForRefactor(transactionID, option.currencyCode);
navigateBack(option.currencyCode);

App/src/pages/iou/request/step/IOURequestStepCurrency.js

Line 85 in 6365aeb

if (pageIndex !== 'confirm') {

And then on IOURequestStepAmount page, we can create a useEffect to restore the currency if this page is unmounted without saving

1. Create a ref to know the amount is saved or not

const isSavedAmountAndCurrency = useRef(false);

2. Update this to true in navigateToNextPage

isSavedAmountAndCurrency.current = true;

App/src/pages/iou/request/step/IOURequestStepAmount.js

Line 73 in 6365aeb

const navigateToNextPage = ({amount}) => {

3. Create a useEffect to restore the currency

useEffect(() => {
    return () => {
        if (isSavedAmountAndCurrency.current) {
            return;
        }
        IOU.setMoneyRequestCurrency_temporaryForRefactor(transactionID, originalCurrency);
    }
}, [])

What alternative solutions did you explore? (Optional)

NA