[HOLD for payment 2024-01-24] [$500] Web - Workspace - The initial selection applies to the new name too

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.17.1
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

1. Navigate to https://staging.new.expensify.com/
2. Log in with an expensifail account
3. Create a workspace
4. Create a room named "asd"
5. Rename the room by selecting "asd" and replacing it with this text from the clipboard "the user is able to select"

Expected Result:

The previous selection shouldn't be applied to the pasted text.

Actual Result:

The initial selection applies to the new name too.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6326857_1703692738965.bandicam_2023-12-26_16-01-44-803.mp4

View all open jobs on GitHub

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01e5da23ce75593d7a

[melvin-bot]

Triggered auto assignment to @JmillsExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @getusha (External)

[paultsimura]

Proposal

Please re-state the problem that we are trying to solve in this issue.

When replacing the text in the room name, the selection remains.

What is the root cause of that problem?

This is happening because of the following code:

App/src/components/RoomNameInput/index.js

Lines 35 to 42 in 054eb86

	if (modifiedRoomName !== newRoomNameWithHash) {
	const offset = modifiedRoomName.length - oldRoomNameWithHash.length;
	const newSelection = {
	start: selection.start + offset,
	end: selection.end + offset,
	};
	setSelection(newSelection);
	}

It was intended to prevent the cursor from jumping to the end while adding a space (that should be replaced with - in the room name). However, this code did not consider the active selection. So similar bug can be observed when we select some symbol and press space – the selection remains, while we just should place the cursor at the end of the replaced selection.

What changes do you think we should make in order to solve the problem?

There is no need to move the start of the selection along with the end of it. We should discard the selection and move the cursor to the end of the replaced text (as seen in the recording below):

        if (modifiedRoomName !== newRoomNameWithHash) {
            const offset = modifiedRoomName.length - oldRoomNameWithHash.length;
            const newSelection = {
-               start: selection.start + offset,
+               start: selection.end + offset,
                end: selection.end + offset,
            };
            setSelection(newSelection);
        }

Result:

Screen.Recording.2023-12-27.at.19.35.28.mov

What alternative solutions did you explore? (Optional)

[yh-0218]

Proposal

Please re-state the problem that we are trying to solve in this issue.

When replacing the text in the room name, the selection remains.

What is the root cause of that problem?

This is happening because of the following code:

App/src/components/RoomNameInput/index.js

Lines 35 to 42 in 054eb86

	if (modifiedRoomName !== newRoomNameWithHash) {
	const offset = modifiedRoomName.length - oldRoomNameWithHash.length;
	const newSelection = {
	start: selection.start + offset,
	end: selection.end + offset,
	};
	setSelection(newSelection);
	}

What changes do you think we should make in order to solve the problem?

We need this logic and add new.

if (modifiedRoomName !== newRoomNameWithHash) {
      const newSelection = {
          start: modifiedRoomName.length,
          end: modifiedRoomName.length,
      };
      setSelection(newSelection);
  }

What alternative solutions did you explore? (Optional)

[getusha]

@paultsimura your RCA makes sense, but i am not sure why this is happening on texts with space between words. i am trying to test the solution.

[paultsimura]

i am not sure why this is happening on texts with space between words

This is because, in the room names, the spaces (and iOS-specific dashes) get replaced with dashes:

App/src/libs/RoomNameInputUtils.ts

Lines 6 to 14 in 5c5c862

	function modifyRoomName(roomName: string): string {
	const modifiedRoomNameWithoutHash = roomName
	.replace(/ /g, '-')
	// Replaces the smart dash on iOS devices with two hyphens
	.replace(/—/g, '--');
	return `${CONST.POLICY.ROOM_PREFIX}${modifiedRoomNameWithoutHash}`;
	}

And because of this, only for the names with spaces, this condition becomes true:

App/src/components/RoomNameInput/index.js

Lines 35 to 42 in 5c5c862

	if (modifiedRoomName !== newRoomNameWithHash) {
	const offset = modifiedRoomName.length - oldRoomNameWithHash.length;
	const newSelection = {
	start: selection.start + offset,
	end: selection.end + offset,
	};
	setSelection(newSelection);
	}