[HOLD for payment 2024-03-20] [$500] HIGH: Remove @expensify.sms from SMS mentions

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.21-1
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

1. Navigate to staging.new.expensify.com
2. Go to a #Room that has several members (
3. Enter "@" in the compose box
4. Select phone number member

Expected Result:

Phone number should be displayed in chat composer correctly

Actual Result:

Phone number member is displayed with suffix @expensify.sms

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6331567_1704308723379.Recording__1683.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0178aad4878bea5bbe
• Upwork Job ID: 1742631934961524736
• Last Price Increase: 2024-01-17
• Automatic offers:
• c3024 | Reviewer | 28118032
• FitseTLT | Contributor | 28118033

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0178aad4878bea5bbe

[melvin-bot]

Triggered auto assignment to @CortneyOfstad (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @c3024 (External)

[FitseTLT]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Number contacts is displayed with suffix @expensify.sms

What is the root cause of that problem?

This is more of a feature request or improvement and there are two parts:

1. We are passing the login without removing the sms domain suffix to the comment here
   

   App/src/pages/home/report/ReportActionCompose/SuggestionMention.js

   Lines 78 to 79 in 27a51a4

   	const mentionCode = mentionObject.text === CONST.AUTO_COMPLETE_SUGGESTER.HERE_TEXT ? CONST.AUTO_COMPLETE_SUGGESTER.HERE_TEXT : `@${mentionObject.login}`;
   	const commentAfterMention = value.slice(suggestionValues.atSignIndex + suggestionValues.mentionPrefix.length + 1);

2. Currently we are parsing the comment with our ExpensiMark here
   

   App/src/libs/ReportUtils.ts

   Lines 2380 to 2383 in 55746c7

   	function getParsedComment(text: string): string {
   	const parser = new ExpensiMark();
   	return text.length <= CONST.MAX_MARKUP_LENGTH ? parser.replace(text) : lodashEscape(text);
   	}

   
   But now we are only supporting a mention in the form of @+19728974297@expensify.sms here is a code snippet from the library concerning the user mention parsing

            /**
             * This regex matches a valid user mention in a string.
             * A user mention is a string that starts with the '@' symbol and is followed by a valid user's primary login
             *
             * Note: currently we are only allowing mentions in a format of @+19728974297@expensify.sms and @username@example.com
             * The username can contain any combination of alphanumeric letters, numbers, and underscores
             */
            {
                name: 'userMentions',
                regex: new RegExp(`(@here|[a-zA-Z0-9.!$%&+=?^\`{|}-]?)(@${CONST.REG_EXP.EMAIL_PART})(?!((?:(?!<a).)+)?<\\/a>|[^<]*(<\\/pre>|<\\/code>))`, 'gim'),
                replacement: (match, g1, g2) => {
                    if (!Str.isValidMention(match)) {
                        return match;
                    }
                    return `${g1}<mention-user>${g2}</mention-user>`;
                },
            },

What changes do you think we should make in order to solve the problem?

1. We remove the sms domain from the login here
   

   App/src/pages/home/report/ReportActionCompose/SuggestionMention.js

   Lines 78 to 79 in 27a51a4

   	const mentionCode = mentionObject.text === CONST.AUTO_COMPLETE_SUGGESTER.HERE_TEXT ? CONST.AUTO_COMPLETE_SUGGESTER.HERE_TEXT : `@${mentionObject.login}`;
   	const commentAfterMention = value.slice(suggestionValues.atSignIndex + suggestionValues.mentionPrefix.length + 1);

   
   to

 const mentionCode =
                mentionObject.text === CONST.AUTO_COMPLETE_SUGGESTER.HERE_TEXT ? CONST.AUTO_COMPLETE_SUGGESTER.HERE_TEXT : `@${Str.removeSMSDomain(mentionObject.login)}`;
          

2. Now with that being said we need to update our ExpensiMarker to start supporting mentions of phone numbers without sms domains. I kinda simulated the change required in ExpensiMarker user mention logic. Here is a rough idea of how to update it and the result video

const EMAIL_PART =
        "(?=((?=[\\w'#%+-]+(?:\\.[\\w'#%+-]+)*@)[\\w\\.'#%+-]{1,64}@(?:(?=[a-z\\d]+(?:-+[a-z\\d]+)*\\.)(?:[a-z\\d-]{1,63}\\.)+[a-z]{2,63})(?= |_|\\b))(?<end>.*))\\S{3,254}(?=\\k<end>$)";

    const regex = new RegExp(`(@here|[a-zA-Z0-9.!$%&+=?^\`{|}-]?)(@${EMAIL_PART}|@\\+[1-9]\\d{1,14}(?!\\S))(?!((?:(?!<a).)+)?<\\/a>|[^<]*(<\\/pre>|<\\/code>))`, 'gim');

    const replacement = (match, g1, g2) => {
        if (!Str.isValidMention(match)) {
            return match;
        }

        return `${g1}<mention-user>${g2}</mention-user>`;
    };

Result

2024-01-13.17-45-56.mp4

[namhihi237]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Phone number should be displayed in chat composer correctly

What is the root cause of that problem?

We get login when select the phone number in the mention list here

App/src/pages/home/report/ReportActionCompose/SuggestionMention.js

Line 78 in 3826e5d

const mentionCode = mentionObject.text === CONST.AUTO_COMPLETE_SUGGESTER.HERE_TEXT ? CONST.AUTO_COMPLETE_SUGGESTER.HERE_TEXT : `@${mentionObject.login}`;

What changes do you think we should make in order to solve the problem?

We should use formatPhoneNumber() to remove sms domain and parse the Phone Number with phone number as we used many places in this component.

What alternative solutions did you explore? (Optional)

N/A

[aim-salam]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Mention - Number contacts is displayed with suffix @expensify.sms

What is the root cause of that problem?

In SuggestionMention.js,
after phone number mentioned, updateComment( ) show mentionCode as @+XXXXXXX@expensify.sms.

App/src/pages/home/report/ReportActionCompose/SuggestionMention.js

Line 81 in 744e35c

updateComment(`${commentBeforeAtSign}${mentionCode} ${SuggestionsUtils.trimLeadingSpace(commentAfterMention)}`, true);

What changes do you think we should make in order to solve the problem?

Remove @expensify.sms whenever mentionCode is phone number.

//const into let
+            let mentionCode = mentionObject.text === CONST.AUTO_COMPLETE_SUGGESTER.HERE_TEXT ? CONST.AUTO_COMPLETE_SUGGESTER.HERE_TEXT : `@${mentionObject.login}`;
            const commentAfterMention = value.slice(suggestionValues.atSignIndex + suggestionValues.mentionPrefix.length + 1);

+            mentionCode = mentionCode.replace('@expensify.sms','')

Note : But after the chat was submitted, the number didn't get mention.

In reportactioncompose.js, we need to add back '@expensify.sms' into phone number before we submit.

App/src/pages/home/report/ReportActionCompose/ReportActionCompose.js

Lines 279 to 293 in 744e35c

	const submitForm = useCallback(
	(e) => {
	if (e) {
	e.preventDefault();
	}
	const newComment = composerRef.current.prepareCommentAndResetComposer();
	if (!newComment) {
	return;
	}
	onSubmit(newComment);
	},
	[onSubmit],
	);

            const newComment = composerRef.current.prepareCommentAndResetComposer();
            if (!newComment) {
                return;
            }

+           const words = newComment.split(' ')
+           const updatedWords = words.map((word) => {
+                    if (word.charAt(0) === '@' && word.charAt(1) === '+') {
+                        return word + '@expensify.sms';
+                   }
+                   return word;

+                })
+             const updatedComment = updatedWords.join(' ');

        
+            onSubmit(updatedComment);

Screen.Recording.2024-01-13.at.1.52.29.PM.mov

What alternative solutions did you explore? (Optional)

[CortneyOfstad]

@c3024 any thoughts on the proposals above?