[$500] [HOLD for payment 2024-01-17] Expense - App crashes when attempting to request money from a deleted workspace

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.22-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

Precondition: User is an employee of a Collect workspace on Old Dot

1. [Employee] Go to workspace chat
2. [Admin] Delete the workspace on Old Dot
3. [Employee] Click + > Request money
4. [Employee] Enter amount > Next

Expected Result:

App does not crash

Actual Result:

App crashes

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6333470_1704484833865.20240105_134408.mp4

logs.txt

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @marcaaron

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~018ed1f3e02054d0aa
• Upwork Job ID: 1747946417104683008
• Last Price Increase: 2024-01-18

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @marcaaron (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[Pujan92]

Proposal

Please re-state the problem that we are trying to solve in this issue.

App crashes on request money flow for the deleted workspace report

What is the root cause of that problem?

Once workspace gets deleted, the policy will be removed from the onyx and it will be undefined. Here we are trying to access value from undefined which causing the crash. Regression from PR

App/src/components/MoneyTemporaryForRefactorRequestConfirmationList.js

Line 280 in cb00747

const shouldShowTax = isPolicyExpenseChat && policy.isTaxTrackingEnabled;

What changes do you think we should make in order to solve the problem?

We need to safely access the field by checking the policy first to avoid this issue.

[marcaaron]

Cool. Thanks! Do you want to create a PR for this? cc @MonilBhavsar @teneeto @alitoshmatov

[Pujan92]

Yes @marcaaron

[marcaaron]

Cool I can review it let's gooo 🙇