[$250] Remove MoneyRequestDatePage.js and copy any changes since Nov 27 into IOURequestStepDate.js

[tgolen]

This is a part of #29107. You can look at that issue for more context behind the cleanup process.

Problem

The app has two redundant components:

Old Component: MoneyRequestDatePage
New Component IOURequestStepDate

Solution

Following the examples (example 1, example 2), the Old Component needs to be completely removed from the codebase

1. Look at the history of the Old Component
2. If there are any changes since Nov 27, 2023 which have not been added to the New Component, copy those changes
3. Replace all uses of the Old Component with the New Component
4. Remove all traces of Old Component
5. Be sure to update all routes and navigation to use the new :action param (instead of being hard-coded with "create")
6. Update any logic like isEditing to use the new action param from the route

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0155d041c50cef598e
• Upwork Job ID: 1747632794805731328
• Last Price Increase: 2024-01-24
• Automatic offers:
• DylanDylann | Contributor | 28130672
• brunovjk | Contributor | 28132561

[melvin-bot]

Triggered auto assignment to @muttmuure (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[Krishna2323]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Remove MoneyRequestDatePage.js and copy any changes since Nov 27 into IOURequestStepDate.js

What is the root cause of that problem?

Component update

What changes do you think we should make in order to solve the problem?

I checked all the commits after 27th Nov and the new component is updated according to the old component, we just need to remove the file and route created for it. I checked the commits thoroughly but will check again in the PR. There are total 7 commits after 27th Nov in the old component and most of them are about renaming constants and DatePicker component and imports.

Component to remove:
https://github.com/Expensify/App/blob/main/src/pages/iou/MoneyRequestDatePage.js

App/src/libs/Navigation/AppNavigator/ModalStackNavigators.tsx

Line 98 in a7a3e7f

[SCREENS.MONEY_REQUEST.DATE]: () => require('../../../pages/iou/MoneyRequestDatePage').default as React.ComponentType,

We also need to remove all traces from src/libs/Navigation/types.ts & src/libs/Navigation/linkingConfig.ts

App/src/libs/Navigation/linkingConfig.ts

Line 430 in a2f5bd5

[SCREENS.MONEY_REQUEST.DATE]: ROUTES.MONEY_REQUEST_DATE.route,

App/src/libs/Navigation/types.ts

Line 198 in a2f5bd5

[SCREENS.MONEY_REQUEST.DATE]: {

Note: The below 2 steps can be omitted because we only use IOURequestStepDate for IOU creation flow.

Need to update to :action here:

App/src/ROUTES.ts

Line 338 in a2f5bd5

route: 'create/:iouType/date/:transactionID/:reportID',

Need to pass the action here:

App/src/components/MoneyTemporaryForRefactorRequestConfirmationList.js

Line 775 in a2f5bd5

Navigation.navigate(ROUTES.MONEY_REQUEST_STEP_DATE.getRoute(iouType, transaction.transactionID, reportID, Navigation.getActiveRouteWithoutParams()));

Result

[njmulsqb]

I would love to take this!

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0155d041c50cef598e

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @sobitneupane (External)

I want to work on it