[Due for payment 2025-03-21] [$500] Expense - Green dot disappears from LHN when paying one out of many unpaid reports

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.27-1
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

Precondition: There is a Collect workspace on Old Dot with admin and employee
pre-steps to have multiple reports for testing -

• Go to the workspace settings > More features > Enable Workflows
• Go to the Workflows tab in the LHN
• Enable Delay submissions
• Keep the default workflow of Submit and Close

1. [Employee] Create a manual request in the workspace chat and submit it
2. [Employee] Create another manual request and submit it
3. {Admin] Go to workspace chat with employee
4. [Admin] Pay the second submitted report (submitted in Step 2)
5. Note that the LHN does not show green dot
6. [Admin] Click on the preview of first submitted report (Step 1) and return to the main chat

Expected Result:

In Step 4, green dot should still appear for the workspace chat in LHN because there is still unpaid report

Actual Result:

In Step 4, LHN for the workspace chat with unpaid report does not show green dot after paying one of the reports. It only shows green dot when revisiting main chat from the expense report

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6346954_1705607247509.20240119_001119.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01fffa54d6d963be62
• Upwork Job ID: 1748072099859210240
• Last Price Increase: 2025-03-22

Issue Owner

Current Issue Owner: @

Issue Owner

Current Issue Owner: @slafortune

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01fffa54d6d963be62

[melvin-bot]

Triggered auto assignment to @peterdbarkerUK (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @allroundexperts (External)

[lanitochka17]

#wave6-collect-submitters

[tienifr]

Proposal

Please re-state the problem that we are trying to solve in this issue.

In Step 4, LHN for the workspace chat with unpaid report does not show green dot after paying one of the reports. It only shows green dot when revisiting main chat from the expense report.

What is the root cause of that problem?

We're setting the hasOutstandingChildRequest to false immediately here when paying money request, without checking whether there're still more outstanding child requests that are unpaid.

What changes do you think we should make in order to solve the problem?

Check that there're no other outstanding child requests first before setting hasOutstandingChildRequest to false in optimistic data above.

There're a couple of ways to do this:
1.

• Fix the back-end to return hasOutstandingChildRequest: true properly for the unpaid IOU report (currently it's returning hasOutstandingChildRequest: false even though those IOU reports are unpaid)
• Then in here, check the list of IOU report that corresponds to the report preview report actions in the chat report, and only set hasOutstandingChildRequest to false if no other IOU reports have hasOutstandingChildRequest: true

2. Or we can use conditions similar to this to check if the REPORTPREVIEW needs to be paid (instead of using the hasOutstandingChildRequest on the IOU report)

What alternative solutions did you explore? (Optional)

We can add a back-end field outstandingChildRequestCount that is the total count of outstanding child requests (similar idea to the childVisibleActionCount of the reportAction). When we pay the request, in optimistic data we reduce the outstandingChildRequestCount by 1, and only set hasOutstandingChildRequest to false if after paying this request, the outstandingChildRequestCount becomes 0.

[allroundexperts]

I think Option 2 from @tienifr's proposal should work fine and be inline with the code that we are already using.

🎀 👀 🎀 C+ reviewed

[melvin-bot]

Triggered auto assignment to @roryabraham, see https://stackoverflow.com/c/expensify/questions/7972 for more details.