Send money - Unexpected error when sending money to a Hidden contact

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: v1.4.33-3
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause- Internal Team
Slack conversation:

Action Performed:

1. Go to 1:1 DM with a Hidden contact (yonghongkok2+300101@gmail.com).
2. Click + > Send money.
3. Enter amount and confirm send money.
4. Click on the send money preview.

Expected Result:

No error will show up.

Actual Result:

It shows "Unexpected error, please try again later".
Issue is not reproducible when sending money via FAB button.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6360825_1706617797108.20240130_121751__1_.mp4

View all open jobs on GitHub

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @cristipaval (Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[kbecciv]

We think that this bug might be related to #vip-bills
CC @davidcardoza

[cristipaval]

I can't reproduce this one 👀

[cristipaval]

Ah, wait, there have been some CORS errors, according to the console in the screen recording.

[bernhardoj]

@cristipaval I can reproduce this, this happens after #32470. If we send money to a Hidden user, the requestorEmail here is an empty string.

App/src/libs/actions/IOU.js

Lines 2877 to 2880 in cfb6f2c

	const newIOUReportDetails = JSON.stringify({
	amount,
	currency,
	requestorEmail: recipientEmail,

Before #32470, specifically this change, the requestorEmail is undefined and JSON.stringify don't include an undefined value.

I think the API doesn't actually need requestorEmail as it works fine on prod, so maybe we can remove it. Another option is to keep the requestorEmail undefined.

[cristipaval]

Thanks @bernhardoj , I'll look into this one again soon.