[HOLD for payment 2024-02-19] [HOLD for payment 2024-02-15] Web - Report - Blank Concierge report is displayed on back navigation from search page

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.38.0
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

1. Sign up with a new account
2. Click on search bar
3. Click back button

Expected Result:

Concierge report should be opened and report shouldn't be blank

Actual Result:

Blank Concierge report is displayed

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6370432_1707315855833.screen_recording_2024-02-07_at_2.43.00_in_the_afternoon.mp4

View all open jobs on GitHub

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @tgolen (Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[kbecciv]

We think that this bug might be related #vip-vsb
CC @quinthar

[allgandalf]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Blank Concierge report is displayed on back navigation from search page

What is the root cause of that problem?

We don't have onBackBuuttonPress prop passed to HeaderWithBackButton

App/src/pages/SearchPage/index.js

Line 149 in fc4a44f

<HeaderWithBackButton title={translate('common.search')} />

What changes do you think we should make in order to solve the problem?

Update HeaderWithBackButton to the following

<HeaderWithBackButton
                        title={translate('common.search')}
                        onBackButtonPress={Navigation.goBack}
                    />

What alternative solutions did you explore? (Optional)

N/A

[situchan]

regression from #35058
cc: @lukemorawski

[tgolen]

@lukemorawski Is this something you will be able to fix ASAP?

[situchan]

The root cause is same as other holding issues like #35965, #35969
@trjExpensify should we hold this as well?

[tgolen]

Yeah, I think we should. I'll put this on HOLD.