[HOLD for payment 2024-02-26] [HIGH] Move the policy tax enabled property to tax key

[mountiny]

Problem

Part of #36171

The policy. isTaxTrackingEnabled property does not exist in this shape in our policy data in database. Its saved as policy.tax.trackingEnabled : boolean. Given we are updating how the policy changes are being saved and propagated to the clients, its cleaner to keep this structure same in Onyx as well. Having different code and different data schema throughout the stack results in less straightforward, more confusing, and more bug prone code

Solution

Update the Policy schema and usage of the policy.isHarvestingEnabled property to expect this data in policy.tax.trackingEnabled : boolean format. Update the backend API to also return the data in this shape.

Steps:

1. Update the App to accept both formats. If policy.tax.trackingEnabled is not available, fallback to policy. isTaxTrackingEnabled in the mean time
2. Update Web to send the data as policy.tax.trackingEnabled
3. Update Auth to do the same
4. Remove the fallback for policy.isTaxTrackingEnabled from the App

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01c25bc5a392761ffc
• Upwork Job ID: 1755684468719345664
• Last Price Increase: 2024-02-08

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01c25bc5a392761ffc

[melvin-bot]

Triggered auto assignment to Contributor Plus for review of internal employee PR - @ishpaul777 (Internal)

[melvin-bot]

@mountiny, @ishpaul777 Whoops! This issue is 2 days overdue. Let's get this updated quick!

[mountiny]

I am unfortunately ill, doing bare minimum now to unblock peeps. Will look if I can squeeze this one in too

[ishpaul777]

Wishing you a speedy recovery! 🌟