[HOLD for payment 2024-04-15] [$500] [Simplified Collect][Categories] - "Categorize all expense" switch is not disabled when all categories are disabled

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: v1.4.45-1

Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause internal team
Slack conversation:

Action Performed:

Precondition:

• User is admin of Collect workspace that has categories.
• All categories are disabled in the Collect workspace.

1. Go to staging.new.expensify.com
2. Go to workspace settings.
3. Select the Collect workspace.
4. Click Categories.
5. Click Settings.
6. Click on the toggle.

Expected Result:

"Categorize all expense" switch should be disabled.

Actual Result:

"Categorize all expense" switch can be toggled on and off. On Old Dot, the switch is disabled when all categories are disabled.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6397092_1709215690576.20240229_113907.mp4

Add any screenshot/video evidence

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~014c2567013c13680f
• Upwork Job ID: 1771256687469146112
• Last Price Increase: 2024-03-22
• Automatic offers:
• getusha | Reviewer | 0
• tienifr | Contributor | 0

[melvin-bot]

Triggered auto assignment to @abekkala (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @luacmartins (Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[m-natarajan]

We think that this bug might be related to #wave8-collect-admins
cc @zanyrenney

[m-natarajan]

@luacmartins FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

[eucool]

Proposal

Please re-state the problem that we are trying to solve in this issue.

"Categorize all expense" switch is not disabled when all categories are disabled

What is the root cause of that problem?

We don't have a conditional rendering check to see if it is disabled:

App/src/pages/workspace/categories/WorkspaceCategoriesSettingsPage.tsx

Lines 44 to 50 in 104565b

	<View style={[styles.flexRow, styles.mb5, styles.mr2, styles.alignItemsCenter, styles.justifyContentBetween]}>
	<Text style={[styles.textNormal, styles.colorMuted]}>{translate('workspace.categories.requiresCategory')}</Text>
	<Switch
	isOn={policy?.requiresCategory ?? false}
	accessibilityLabel={translate('workspace.categories.requiresCategory')}
	onToggle={updateWorkspaceRequiresCategory}
	/>

What changes do you think we should make in order to solve the problem?

We need to check the boolean areCategoriesEnabled which would be implemented as per comments, and allow the toggle if the value is true or else simply disable the toggle , Also we need to check the length of the enabled categories, if it is 0 then simply disable the button:

<Switch
      isOn={!policy?.areCategoriesEnabled}
      disabled={OptionsListUtils.getEnabledCategoriesCount( ) === 0}
      accessibilityLabel={translate('workspace.categories.requiresCategory')}
      onToggle={updateWorkspaceRequiresCategory}
                                    />

What alternative solutions did you explore? (Optional)

N/A