[HOLD for payment 2024-03-22] [$500] - MEDIUM - Workspace switcher - WS switcher resets to Expensify when creating a room under the same WS

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.45-1
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

1. Go to staging.new.expensify.com
2. Open workspace switcher
3. Select a workspace
4. Go to FAB > Start chat > Room
5. Create a room under the same workspace in Step 2

Expected Result:

The workspace switcher should be preserved when the room is created since it is under the same workspace

Actual Result:

The workspace switcher resets to Expensify

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6397316_1709226113276.20240229_223918.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01432a2ba6b78d56dc
• Upwork Job ID: 1764475541802258432
• Last Price Increase: 2024-03-11
• Automatic offers:
• DylanDylann | Contributor | 0
• gijoe0295 | Contributor | 0

[melvin-bot]

Triggered auto assignment to @bfitzexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[lanitochka17]

@bfitzexpensify FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[gijoe0295]

Proposal

Please re-state the problem that we are trying to solve in this issue.

WS switcher switches to Expensify when creating a room under the same WS

What is the root cause of that problem?

We already have the logic the keep the workspace open when the room belongs to that same workspace:

App/src/libs/Navigation/dismissModalWithReport.ts

Lines 47 to 53 in 5bcba77

	const shouldOpenAllWorkspace = isEmptyObject(targetReport) ? true : !doesReportBelongToWorkspace(targetReport, policyMemberAccountIDs, policyID);
	if (shouldOpenAllWorkspace) {
	switchPolicyID(navigationRef, {route: ROUTES.HOME});
	} else {
	switchPolicyID(navigationRef, {policyID, route: ROUTES.HOME});
	}

But at the time dismissModal was called, the optimistic data in addPolicyReport might not be updated to Onyx, causing the report with reportID passed here to be empty (because it is an optimistic report) and consequently failed the shouldOpenAllWorkspace check above.

What changes do you think we should make in order to solve the problem?

Use dismissModalWithReport here to make sure the report is not empty.

What alternative solutions did you explore? (Optional)

Add InteractionManager.runAfterInteractions to the dismissModal here to delay that function call to make sure the optimistic data is updated.

Optionally, we can automatically switches to whichever corresponding workspace of the room by removing the shouldOpenAllWorkspace check here.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01432a2ba6b78d56dc

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @alitoshmatov (External)