[HOLD for payment 2024-03-14] [$500] Split scan - Scan split request can be created without Merchant

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.47-0
Reproducible in staging?: yes
Reproducible in production?: no
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause internal team
Slack conversation:

Action Performed:

1. Go to staging.new.expensify.com
2. Go to workspace chat.
3. Go to + > Split scan.
4. Create a split scan request.
5. Click on the split scan preview.
6. Enter amount and save it.
7. Click Split.

Expected Result:

App will prevent the bill from splitting because merchant is not entered as merchant is a requirement in workspace expense.

Actual Result:

Scan split request can be created without Merchant.

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop - test build not yet available

Screenshots/Videos

Add any screenshot/video evidence

Bug6402232_1709602219456.bandicam_2024-03-05_07-02-15-673__1_.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01718d2bb982e868c3
• Upwork Job ID: 1764959862414594048
• Last Price Increase: 2024-03-05

[melvin-bot]

Triggered auto assignment to @laurenreidexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @techievivek (Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[m-natarajan]

We think that this bug might be related to #wave7-collect-submitters
cc @RachCHopkins

[m-natarajan]

@techievivek FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

[dukenv0307]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Scan split request can be created without Merchant.

What is the root cause of that problem?

We don't display an error if we're editing the split bill

App/src/components/MoneyRequestConfirmationList.js

Line 285 in a79c119

const shouldDisplayMerchantError = props.isPolicyExpenseChat && shouldDisplayFieldError && isMerchantEmpty;

App/src/components/MoneyRequestConfirmationList.js

Lines 277 to 279 in a79c119

	if (!props.isEditingSplitBill) {
	return false;
	}

What changes do you think we should make in order to solve the problem?

We can remove this check to allow display error while editing split bill

App/src/components/MoneyRequestConfirmationList.js

Lines 277 to 279 in a79c119

	if (!props.isEditingSplitBill) {
	return false;
	}

What alternative solutions did you explore? (Optional)

NA