[HOLD for payment 2024-04-05] [$250] [Categories] - Category row is not grayed out entirely when disabled offline

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.52-0
Reproducible in staging?: y
Reproducible in production?: no
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: applause internal team
Slack conversation:

Action Performed:

Precondition:

• User is an admin of Collect workspace.

1. Go to staging.new.expensify.com.
2. Go to Settings > Workspaces > Collect workspace.
3. Go to Categories.
4. Go offline.
5. Click on the checkbox of any category.
6. Click dropdown menu > Disable categories (or Enable if disabled).

Expected Result:

The entire category row will appear grayed out.

Actual Result:

Only the status column is grayed out.

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6412862_1710369793014.bandicam_2024-03-14_04-34-17-866.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~013df311dce09e48bb
• Upwork Job ID: 1768698540734349312
• Last Price Increase: 2024-03-15
• Automatic offers:
• cubuspl42 | Reviewer | 0
• Krishna2323 | Contributor | 0

Issue Owner

Current Issue Owner: @puneetlath

[melvin-bot]

Triggered auto assignment to @puneetlath (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Current assignee @puneetlath is eligible for the Engineering assigner, not assigning anyone new.

[ikevin127]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Category row is not grayed out entirely when disabled offline, only the status column is grayed out.

What is the root cause of that problem?

Offending PR: #37734.

The issue comes from this line:

App/src/pages/workspace/categories/WorkspaceCategoriesPage.tsx

Line 293 in 13f8bc0

sections={[{data: categoryList, indexOffset: 0, isDisabled: false}]}

where isDisabled is always false for all SectionList items, overriding the individual item isDisabled passed within categoryList mapping.

What changes do you think we should make in order to solve the problem?

Remove the isDisabled: false from SectionList sections and only keep the one from the item mapping itself within categoryList here:

App/src/pages/workspace/categories/WorkspaceCategoriesPage.tsx

Line 83 in 13f8bc0

isDisabled,

this alone will disable the whole SectionList item because of how the logic works here:

App/src/components/SelectionList/BaseSelectionList.tsx

Line 317 in 13f8bc0

const isDisabled = !!section.isDisabled || item.isDisabled;

specifically fallback to item.isDisabled if section.isDisabled is not passed.

[akinwale]

I believe this behaviour is intentional since it's the state value (enabled / disabled) that's changing. @ArekChr can confirm.

[Krishna2323]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Categories - Category row is not grayed out entirely when disabled offline

What is the root cause of that problem?

Offending PR: #37734

We set pendingFields instead of pendingAction when enabling/disabling category

App/src/libs/actions/Policy.ts

Lines 2655 to 2657 in 13f8bc0

	pendingFields: {
	enabled: CONST.RED_BRICK_ROAD_PENDING_ACTION.UPDATE,
	},

What changes do you think we should make in order to solve the problem?

Instead of adding pendingFields we should add pendingAction: CONST.RED_BRICK_ROAD_PENDING_ACTION.UPDATE when updating the category, just like we do when creating a category. Or just add pendingAction without removing pendingFields.

Result

enabled.disable_category_pendingAction.mp4