[HOLD for payment 2024-03-25] [Wave Collect] [Tags] Tag - Tag row is not grayed out when created offline

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Found when validating PR : #38158

Version Number: 1.4.52-0
Reproducible in staging?: Y
Reproducible in production?: N
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal team

Action Performed:

Precondition:

• User is an admin of Collect workspace.

1. Go to staging.new.expensify.com.
2. Go to Profile > Workspaces > Collect workspace.
3. Go to Tags.
4. Go offline.
5. Click Add tag.
6. Add a tag.

Expected Result:

Tag row is grayed out when created offline

Actual Result:

Tag row is not grayed out when created offline

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6413023_1710383772345.bandicam_2024-03-14_10-32-45-394.mp4

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @slafortune (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @madmax330 (Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[izarutskaya]

@madmax330 I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

[izarutskaya]

We think that this bug might be related to #wave-collect - Release 1
CC @trjExpensify

[nkdengineer]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Tag row is not grayed out when created offline

What is the root cause of that problem?

We don't get the pendingAction of tag when get the tag list to display in WorkspaceTagsPage

App/src/pages/workspace/tags/WorkspaceTagsPage.tsx

Line 72 in b7a230e

value: value.name,

What changes do you think we should make in order to solve the problem?

We should return an extra field pendingAction: value. pendingAction here.

App/src/pages/workspace/tags/WorkspaceTagsPage.tsx

Line 72 in b7a230e

value: value.name,

What alternative solutions did you explore? (Optional)

NA