[HOLD for payment 2024-05-07] [$250] Android - Room-Tapping create room with specific description directs to concierge page

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.52
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4426548
Issue reported by: Applause - Internal Team

Action Performed:

1. Launch app
2. Tap fab-- start chat --- Room
3. Enter room name
4. Paste the below text in room description

we can close this to focus on more urgent issue this is just a minor viewing discrepancy

can close this to focus on more urgent issue this is just a minor viewing discrepancy

can close this to focus on more urgent issue this is just a minor viewing discrepancy

can close this to focus on more urgent issue this is just a minor viewing discrepancy

5. Tap create room

Expected Result:

When user taps create room, he must be directed to room page and must not be redirected to concierge page

Actual Result:

When user taps create room with specific text entered in room description. , he is directed to room page but within seconds redirected to concierge page

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6413077_1710398840280.Usethis.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0171e588018217e1f4
• Upwork Job ID: 1772221395416739840
• Last Price Increase: 2024-04-01
• Automatic offers:
• shubham1206agra | Reviewer | 0
• rmm-fl | Contributor | 0

[melvin-bot]

Triggered auto assignment to @greg-schroeder (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[lanitochka17]

We think that this bug might be related to #vip-vsp
CC @quinthar

[lanitochka17]

@greg-schroeder FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[rmm-fl]

Proposal

Please re-state the problem that we are trying to solve in this issue.

create room with specific description directs to concierge page

What is the root cause of that problem?

Server returns description too long error

What changes do you think we should make in order to solve the problem?

Because the server checks the final html generated length, instead of markdown, we should use the same final html generated string length for validation.
Validation step doesn't check for description length, we should add length validation here:

App/src/pages/workspace/WorkspaceNewRoomPage.tsx

Lines 163 to 181 in 0a512c9

	(values: FormOnyxValues<typeof ONYXKEYS.FORMS.NEW_ROOM_FORM>): OnyxCommon.Errors => {
	const errors: {policyID?: string; roomName?: string} = {};
	if (!values.roomName || values.roomName === CONST.POLICY.ROOM_PREFIX) {
	// We error if the user doesn't enter a room name or left blank
	ErrorUtils.addErrorMessage(errors, 'roomName', 'newRoomPage.pleaseEnterRoomName');
	} else if (values.roomName !== CONST.POLICY.ROOM_PREFIX && !ValidationUtils.isValidRoomName(values.roomName)) {
	// We error if the room name has invalid characters
	ErrorUtils.addErrorMessage(errors, 'roomName', 'newRoomPage.roomNameInvalidError');
	} else if (ValidationUtils.isReservedRoomName(values.roomName)) {
	// Certain names are reserved for default rooms and should not be used for policy rooms.
	ErrorUtils.addErrorMessage(errors, 'roomName', ['newRoomPage.roomNameReservedError', {reservedName: values.roomName}]);
	} else if (ValidationUtils.isExistingRoomName(values.roomName, reports, values.policyID ?? '')) {
	// Certain names are reserved for default rooms and should not be used for policy rooms.
	ErrorUtils.addErrorMessage(errors, 'roomName', 'newRoomPage.roomAlreadyExistsError');
	} else if (values.roomName.length > CONST.TITLE_CHARACTER_LIMIT) {
	ErrorUtils.addErrorMessage(errors, 'roomName', ['common.error.characterLimitExceedCounter', {length: values.roomName.length, limit: CONST.TITLE_CHARACTER_LIMIT}]);
	}

Solution

const descriptionLength = ReportUtils.getCommentLength(values.reportDescription);
if (descriptionLength > CONST.DESCRIPTION_LIMIT) {
    ErrorUtils.addErrorMessage(errors, 'reportDescription', ['common.error.characterLimitExceedCounter', {length: descriptionLength, limit: CONST.DESCRIPTION_LIMIT}]);
}

What alternative solutions did you explore? (Optional)

[melvin-bot]

@greg-schroeder Huh... This is 4 days overdue. Who can take care of this?

[melvin-bot]

⚠️ Could not update price automatically because there is no linked Upwork Job ID. The BZ team member will need to update the price manually in Upwork.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0171e588018217e1f4