-
Notifications
You must be signed in to change notification settings - Fork 3.7k
Description
HOLD
Held on BE changes from https://github.com/Expensify/Expensify/issues/379978
Once those changes are made, I will update this issue
Background
New Card App TS data: #38590
Here's the idea:
If you have a ton of cards, we need to group them properly in app. Right now, all the cards link to /expensify.com and do not display the correct card.
We instead need to group cards in this way:
Any card that is !isAdminIssuedVirtualCard will be grouped in a row with title Expensify Card. In the case a user has two domains with two expensify cards, we would have two rows with the title Expensify Card and clicking on each row will use the domain in the URL to open the card page. In other words, If !isAdminIssuedVirtualCard, group by domain
If for some reason, a user has more than 1 physical or virtual card in their domain, we will display them all on the linked card page and we will show the activate button if ANY of the cards in this group are in the NOT_ACTIVATED state.
Any card that is isAdminIssuedVirtualCard will have it's own row. Each of these cards should have a cardTitle. We can use the title of the card for the URL to open the card page. In other words, If isAdminIssuedVirtualCard, each card is it's own group
New Copy:
We also will add a blurb about the limit on the CardDetailsPage. This will be stored in card.limitType and there are three descriptions we will need to add to es/en
monthly: You can spend up to formattedLimit on this card per month. The limit will reset on the 1st day of each calendar month.
fixed: You can spend up to formattedLimit on this card, and then it will deactivate.
limit: You can spend up to formattedLimit on this card, and the limit will reset as your submitted expenses are approved.
