[hold for payment 2024-04-29] [$500] [Held requests] System message for hold request shows a comma as reason

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

**Version Number:**1.4.54-1
Reproducible in staging?: y
Reproducible in production?: y
Issue reported by: Applause - Internal Team

Action Performed:

1. Go to staging.new.expensify.com.
2. Request money from any user.
3. Navigate to request details page.
4. Click 3-dot menu > Hold request.
5. Add a reason and save it.

Expected Result:

The system message for hold request will show the entered reason.

Actual Result:

The system message for hold request briefly shows the entered reason, then it changes to a comma.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6419227_1710853518973.bandicam_2024-03-19_21-02-32-738.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01b056a4fad087d390
• Upwork Job ID: 1770105583965515776
• Last Price Increase: 2024-03-19
• Automatic offers:
• mkhutornyi | Reviewer | 0

[melvin-bot]

Triggered auto assignment to @joekaufmanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[kbecciv]

@joekaufmanexpensify I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

[kbecciv]

We think that this bug might be related to #wave-collect - Release 1

[shahinyan11]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Hold request - System message for hold request shows a comma as reason

What is the root cause of that problem?

When we create optimistic hold report action we set the comment as 1 index of message but when we receive data from server the comment becomes 3 index in message array. Since we always take 1 index of the message array here, it is displayed right after crating and disappears when the data is updated based on the response from the server.

What changes do you think we should make in order to solve the problem?

Take the index 3 from action.message instead of 1 here

translate('iou.heldRequest', {comment: action.message?.[3]?.text ?? ''})

What alternative solutions did you explore? (Optional)

Since implementing above changes causes a delay in displaying the comment because the index 3 does not exist in the optimistic data and is added after the data is received from the server, I suggest using the below opinion which will display index 3 if it exists otherwise index 1

translate('iou.heldRequest', {comment: action.message?.[3]?.text ?? action.message?.[1]?.text ?? ''})

[allgandalf]

Proposal

Please re-state the problem that we are trying to solve in this issue.

System message for hold request shows a comma as reason

What is the root cause of that problem?

When we submit the Hold reason first time, we store it at the 1nd index, but when we fetch it again when we call Open Report, this time, the BE returns that the value is stored at the 4th index, this causes the inconsistency:

What changes do you think we should make in order to solve the problem?

Update the condition to check if the 3rd index exits and if not then display the text at the 1st index:

App/src/pages/home/report/ReportActionItem.tsx

Lines 519 to 520 in 34fa987

	} else if (action.actionName === CONST.REPORT.ACTIONS.TYPE.HOLD) {
	children = <ReportActionItemBasicMessage message={translate('iou.heldRequest', {comment: action.message?.[1].text ?? ''})} />;

} else if (action.actionName === CONST.REPORT.ACTIONS.TYPE.HOLD) {
            console.log('action.message:', action.message);
            children = <ReportActionItemBasicMessage message={translate('iou.heldRequest', {comment: action.message?.[3]?.text ?? action.message?.[1].text})} />;
        } 

What alternative solutions did you explore? (Optional)

N/A

[joekaufmanexpensify]

Def seems like a bug.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01b056a4fad087d390

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @mkhutornyi (External)