[$500] 'Hmm its not here' displayed when refreshing expensify classic page

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.56-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers): shussain+web@applausemail.com
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by:
Slack conversation:

Issue found when executing PR #37955

Action Performed:

1. Navigate to Settings - Switch to Expensify Classic
2. Choose any option
3. Click on the Next button
4. Verify input is auto-focused
5. Now refresh page

Expected Result:

'Hmm its not here' should not be displayed when refreshing expensify classic page

Actual Result:

'Hmm its not here' displayed when refreshing expensify classic page

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6423438_1711128399760.2024-03-22_22-16-14.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01c71608c41784a351
• Upwork Job ID: 1772068230275534848
• Last Price Increase: 2024-03-25
• Automatic offers:
• hoangzinh | Reviewer | 0
• GandalfGwaihir | Contributor | 0

Issue Owner

Current Issue Owner: @adelekennedy

[melvin-bot]

Triggered auto assignment to @adelekennedy (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[lanitochka17]

@adelekennedy FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[ZhenjaHorbach]

I think this should be fixed in this PR
#38856

[allgandalf]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The real problem here is that the back screen central pane gets to the chats window and doesn't stay on settings page

What is the root cause of that problem?

We do not map the Switch to expensify screen to Central Pane:

App/src/libs/Navigation/linkingConfig/CENTRAL_PANE_TO_RHP_MAPPING.ts

Lines 4 to 22 in 2003844

	const CENTRAL_PANE_TO_RHP_MAPPING: Partial<Record<CentralPaneName, string[]>> = {
	[SCREENS.SETTINGS.PROFILE.ROOT]: [
	SCREENS.SETTINGS.PROFILE.DISPLAY_NAME,
	SCREENS.SETTINGS.PROFILE.CONTACT_METHODS,
	SCREENS.SETTINGS.PROFILE.CONTACT_METHOD_DETAILS,
	SCREENS.SETTINGS.PROFILE.NEW_CONTACT_METHOD,
	SCREENS.SETTINGS.PROFILE.STATUS_CLEAR_AFTER,
	SCREENS.SETTINGS.PROFILE.STATUS_CLEAR_AFTER_DATE,
	SCREENS.SETTINGS.PROFILE.STATUS_CLEAR_AFTER_TIME,
	SCREENS.SETTINGS.PROFILE.STATUS,
	SCREENS.SETTINGS.PROFILE.PRONOUNS,
	SCREENS.SETTINGS.PROFILE.TIMEZONE,
	SCREENS.SETTINGS.PROFILE.TIMEZONE_SELECT,
	SCREENS.SETTINGS.PROFILE.LEGAL_NAME,
	SCREENS.SETTINGS.PROFILE.DATE_OF_BIRTH,
	SCREENS.SETTINGS.PROFILE.ADDRESS,
	SCREENS.SETTINGS.PROFILE.ADDRESS_COUNTRY,
	SCREENS.SETTINGS.SHARE_CODE,
	],

What changes do you think we should make in order to solve the problem?

Add the Screen SCREENS.SETTINGS.EXIT_SURVEY.REASON to the CENTRAL_PANE_TO_RHP_MAPPING and this issue will be solved

Also add subpages:

App/src/libs/Navigation/linkingConfig/config.ts

Lines 350 to 359 in 2003844

	},
	[SCREENS.SETTINGS.EXIT_SURVEY.REASON]: {
	path: ROUTES.SETTINGS_EXIT_SURVEY_REASON,
	},
	[SCREENS.SETTINGS.EXIT_SURVEY.RESPONSE]: {
	path: ROUTES.SETTINGS_EXIT_SURVEY_RESPONSE.route,
	},
	[SCREENS.SETTINGS.EXIT_SURVEY.CONFIRM]: {
	path: ROUTES.SETTINGS_EXIT_SURVEY_CONFIRM.route,
	},

What alternative solutions did you explore? (Optional)

N/A

[allgandalf]

Note

@adelekennedy , the real bug is actually different over here, can you please check the video, the Central Pane changes on refresh

[ishpaul777]

i dont think this is related to #38856, here issue is the background page is not persisting after the refresh which is what we should fix by adding these routes to CENTRAL_PANE_TO_RHP_MAPPING(@GandalfGwaihir's proposal)

[ZhenjaHorbach]

@ishpaul777
There are 2 different problems here
First related with the background page

Second with 'Hmm its not here' (which relevant for Report screen when any RHP page is open) and I think this should be fixed in #38856

For example :

Screen.Recording.2024-03-24.at.22.19.13.mov

[allgandalf]

@ZhenjaHorbach , I checked over here, if we implement my proposal we don't have this problem as now we have mapped the Central Pane to RHP, thanks :)

Video:

simplescreenrecorder-2024-03-25_03.27.23.mp4

c.c. @adelekennedy

[ishpaul777]

@ZhenjaHorbach good catch, i understand issue now. i think we can fix that in that PR.

[allgandalf]

@ZhenjaHorbach good catch, i understand issue, i think we can fix that in that PR.

Yes @ishpaul777 , that issue for will surely get fixed in #38856 as it happens mostly for report pages, but we need to address the current bug which we found in this issue :)