[$250] After resizing issue on Desktop, the 3 dot WS menu is aligned to the high left corner

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.56-6
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause internal team
Slack conversation:

Action Performed:

1. Open the New Expensify Desktop app
2. Go to Profile > Workspaces
3. Undersize the Desktop app window just a bit
4. Click on the 3 dot menu next to any workspace

Expected Result:

User expects the 3 dot menu to be aligned near the WS that was clicked on

Actual Result:

If the window is just a bit undersized, the 3 dot popup will be placed all the way in the upper left hand corner

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6427869_1711484364069.3_dot_menu_opens_in_upper_left_corner_when_window_size_is_a_bit_smaller_.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01875fade5a95855b5
• Upwork Job ID: 1773127686321221632
• Last Price Increase: 2024-03-27

Issue Owner

Current Issue Owner: @madmax330

[melvin-bot]

Triggered auto assignment to @bfitzexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[Krishna2323]

Proposal

Please re-state the problem that we are trying to solve in this issue.

After resizing issue on Desktop, the 3 dot WS menu is aligned to the high left corner

What is the root cause of that problem?

In WorkspacesListRow we are using isNarrow for showing the ThreeDotsMenu, and isNarrow is true when the isMediumScreenWidth is true but we should be showing passing anchorPosition={ {horizontal: 0, vertical: 0}} only when isSmallScreenWidth is true because thats the point we show the modal for small width devices which covers the whole screen.

App/src/pages/workspace/WorkspacesListRow.tsx

Lines 155 to 172 in 4eb0705

	{isNarrow &&
	(!isJoinRequestPending ? (
	<>
	<BrickRoadIndicatorIcon brickRoadIndicator={brickRoadIndicator} />
	<ThreeDotsMenu
	menuItems={menuItems}
	anchorPosition={{horizontal: 0, vertical: 0}}
	disabled={shouldDisableThreeDotsMenu}
	/>
	</>
	) : (
	<Badge
	text={translate('workspace.common.requested')}
	textStyles={styles.textStrong}
	badgeStyles={[styles.alignSelfCenter, styles.badgeBordered]}
	icon={Expensicons.Hourglass}
	/>
	))}

App/src/pages/workspace/WorkspacesListPage.tsx

Line 128 in 4eb0705

const isLessThanMediumScreen = isMediumScreenWidth || isSmallScreenWidth;

What changes do you think we should make in order to solve the problem?

We can wrap the ThreeDotsMenu with a View, just like we do with the ThreeDotsMenu for wide screen.

App/src/pages/workspace/WorkspacesListRow.tsx

Lines 155 to 172 in 4eb0705

	{isNarrow &&
	(!isJoinRequestPending ? (
	<>
	<BrickRoadIndicatorIcon brickRoadIndicator={brickRoadIndicator} />
	<ThreeDotsMenu
	menuItems={menuItems}
	anchorPosition={{horizontal: 0, vertical: 0}}
	disabled={shouldDisableThreeDotsMenu}
	/>
	</>
	) : (
	<Badge
	text={translate('workspace.common.requested')}
	textStyles={styles.textStrong}
	badgeStyles={[styles.alignSelfCenter, styles.badgeBordered]}
	icon={Expensicons.Hourglass}
	/>
	))}

<View ref={threeDotsMenuContainerRef}>
    <ThreeDotsMenu
        onIconPress={() => {
            if (isSmallScreenWidth) {
                return;
            }
            threeDotsMenuContainerRef.current?.measureInWindow((x, y, width, height) => {
                setThreeDotsMenuPosition({
                    horizontal: x + width,
                    vertical: y + height,
                });
            });
        }}
        menuItems={menuItems}
        anchorPosition={isSmallScreenWidth ? {horizontal: 0, vertical: 0} : threeDotsMenuPosition}
        anchorAlignment={
            isSmallScreenWidth ? {horizontal: CONST.MODAL.ANCHOR_ORIGIN_HORIZONTAL.RIGHT, vertical: CONST.MODAL.ANCHOR_ORIGIN_VERTICAL.TOP} : undefined
        }
        shouldOverlay={!isSmallScreenWidth}
        disabled={shouldDisableThreeDotsMenu}
    />
</View>

Optional: If we still want to pass anchorPosition as {horizontal: 0, vertical: 0}, we can use isSmallScreenWidth variable and pass {horizontal: 0, vertical: 0} instead of anchorPosition if it is true, similarly we can pass undefined for anchorAlignment and false for shouldOverlay.

Result

Alternatively

We should remove isMediumScreenWidth from const isLessThanMediumScreen = isMediumScreenWidth || isSmallScreenWidth;.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01875fade5a95855b5

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @thesahindia (External)

[melvin-bot]

Upwork job price has been updated to $250

[bfitzexpensify]

Bringing this one down to $250 as it's a minor bug.