[HOLD for payment 2024-05-02] [$250] Workspace features - App shows two not here pages when opening inaccessible feature page

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.57-2
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team

Action Performed:

1. Go to staging.new.expensify.com.
2. Go to feature page of a workspace in which user is not a member. (https://staging.new.expensify.com/settings/workspaces/CE183C61DF23465B/distance-rates
   )

Expected Result:

App will show not here page in full screen

Actual Result:

App shows not here page on the left and right

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01a372bbcef3dbf2a7
• Upwork Job ID: 1773511214615310336
• Last Price Increase: 2024-03-29
• Automatic offers:
• alitoshmatov | Reviewer | 0

[melvin-bot]

Triggered auto assignment to @greg-schroeder (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[lanitochka17]

@greg-schroeder FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[lanitochka17]

We think that this bug might be related to #wave-control

[Krishna2323]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Workspace features - App shows two not here pages when opening inaccessible feature page

What is the root cause of that problem?

We are using NotFoundPage inside PaidPolicyAccessOrNotFoundComponent & AdminPolicyAccessOrNotFoundComponent. We need to use FullPageNotFoundView.

App/src/pages/workspace/PaidPolicyAccessOrNotFoundWrapper.tsx

Line 53 in 9dbec73

return <NotFoundPage onBackButtonPress={() => Navigation.goBack(ROUTES.WORKSPACE_PROFILE.getRoute(props.policyID))} />;

App/src/pages/workspace/AdminPolicyAccessOrNotFoundWrapper.tsx

Line 53 in 9dbec73

return <NotFoundPage onBackButtonPress={() => Navigation.goBack(ROUTES.WORKSPACE_PROFILE.getRoute(props.policyID))} />;

What changes do you think we should make in order to solve the problem?

We need to use FullPageNotFoundView with shouldShow & shouldForceFullScreen just like we don in FeatureEnabledAccessOrNotFoundComponent.

Pseudo-code:

<FullPageNotFoundView
    shouldShow={shouldShowNotFoundPage}
    shouldForceFullScreen=
    onBackButtonPress={() => Navigation.goBack(ROUTES.WORKSPACE_PROFILE.getRoute(props.policyID))}
/>

There might be few more similar bugs, will try to find and fix those as well.

Optional: We might only want to do this in PaidPolicyAccessOrNotFoundComponent only.

Result

[Krishna2323]

Proposal updated

• Added references

[melvin-bot]

⚠️ Could not update price automatically because there is no linked Upwork Job ID. The BZ team member will need to update the price manually in Upwork.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01a372bbcef3dbf2a7