[HOLD for payment 2024-06-20] [HOLD for payment 2024-06-18] [$250] [TS Migration] Standartize between Boolean or !!

[mountiny]

Follow up issue for TS migration project. Coming from this spreadsheet

Standartize between Boolean or !!

Lets pick the one which can be enforced with eslint

Any more details for this one cc @blazejkustra @fabioh8010

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01111a2979f5f2ac8c
• Upwork Job ID: 1780333266166345728
• Last Price Increase: 2024-04-16
• Automatic offers:
• ishpaul777 | Contributor | 0
• ShridharGoel | Contributor | 0

Issue Owner

Current Issue Owner: @CortneyOfstad

[ShridharGoel]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Standardise between Boolean or !!.

What is the root cause of that problem?

New check using ESlint.

What changes do you think we should make in order to solve the problem?

Slack discussion: https://expensify.enterprise.slack.com/archives/C01GTK53T8Q/p1713329747825759. Looks like we want to go ahead with !!, so the check can look like this:

module.exports = {
    create: function(context) {
        return {
            CallExpression: function(node) {
                if (node.callee.type === "Identifier" && node.callee.name === "Boolean" && node.arguments.length === 1) {
                    context.report({
                        node: node,
                        message: "Use !! instead of Boolean",
                        fix: function(fixer) {
                            const sourceCode = context.getSourceCode();
                            const argumentText = sourceCode.getText(node.arguments[0]);
                            return fixer.replaceText(node, `!!${argumentText}`);
                        }
                    });
                }
            }
        };
    }
};

[melvin-bot]

10 days overdue. Is anyone even seeing these? Hello?

[ShridharGoel]

@mountiny Can we pick this since TS migration is almost done? I've sent a proposal above.

[blazejkustra]

@ShridharGoel Not yet, let's wait until migration is fully finished

[melvin-bot]

12 days overdue. Walking. Toward. The. Light...

[fabioh8010]

This is on hold Melvin..

[blazejkustra]

Details:

We want to standardize with just one approach, !! and Boolean() are almost identical and we want to ensure just one is used in the codebase to avoid cases like this 😅

offline = Boolean(network.shouldForceOffline) || !!network.isOffline;

This includes writing a proposal on Slack, adjusting the code in the repository and perhaps adding an eslint rule that ensures only one approach is used. I myself believe !! is more readable more concise and faster in runtime.

This issue requires a minimal understanding of how Expensify process works, before coding the contributor have to post a Problem/Solution on open-source channel