[$250] Chat - Unread message indicator not displayed after flagging message as offensive

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: v1.4.57-2
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4459671
Issue reported by: Applause - Internal Team

Action Performed:

Pre-requisite: the user must be logged in.

1. Verify you have a chat where the latest messages are not from you.
2. Go to LHN and long press on the chat and mark it as unread.
3. Open the chat and verify that the unread indicator appears on the latest message from the other participant.
4. Long press on the message and flag it as offensive (any option).
5. Send a message.
6. Return to LHN and long press on the chat and mark it as unread.
7. Open the chat.
8. Verify no unread message indicator is displayed.

Expected Result:

Unread message indicator should be displayed on the latest message from the other participant.

Actual Result:

There is no unread message indicator on the chat after flagging as offensive.

Workaround:

n/a

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6429233_1711573068460.Isgj6882_1_.1.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01103e15827eecbf8f
• Upwork Job ID: 1773462943050678272
• Last Price Increase: 2024-03-28
• Automatic offers:
• akinwale | Reviewer | 0
• bernhardoj | Contributor | 0

Issue Owner

Current Issue Owner: @akinwale

[melvin-bot]

Triggered auto assignment to @bfitzexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[kbecciv]

@bfitzexpensify I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[kbecciv]

We think that this bug might be related to #vip-vsb

[bernhardoj]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Mark us unread do nothing when the last action/message is a flagging whisper.

What is the root cause of that problem?

When we mark as unread, we find the latest action that is not coming from the current user and take its created data.

App/src/libs/actions/Report.ts

Lines 1005 to 1013 in 58abe89

	const latestReportActionFromOtherUsers = Object.values(reportActions ?? {}).reduce((latest: ReportAction | null, current: ReportAction) => {
	if (current.actorAccountID !== currentUserAccountID && (!latest || current.created > latest.created)) {
	return current;
	}
	return latest;
	}, null);
	// If no action created date is provided, use the last action's from other user
	const actionCreationTime = reportActionCreated || (latestReportActionFromOtherUsers?.created ?? allReports?.[reportID]?.lastVisibleActionCreated ?? DateUtils.getDBTime(0));

In our case, it takes the whisper created data and subtracts 1 ms from it, and sets it as the new lastReadTime.

App/src/libs/actions/Report.ts

Line 1018 in 58abe89

const lastReadTime = DateUtils.subtractMillisecondsFromDateTime(actionCreationTime, 1);

Then, to decide whether it's unread or not, it checks whether the lastReadTime is smaller than lastVisibleActionCreated.

App/src/libs/ReportUtils.ts

Line 4161 in 58abe89

return lastReadTime < lastVisibleActionCreated || lastReadTime < lastMentionedTime;

You may expect that lastVisibleActionCreated value is the flagging whisper created value, however, that's not the case. Looks like lastVisibleActionCreated doesn't consider a whisper message, with the exception of ACTIONABLEMENTIONWHISPER. So, the lastVisibleActionCreated contains the message created that we flag thus the condition is always false.

What changes do you think we should make in order to solve the problem?

If it's expected that lastVisibleActionCreated doesn't consider some whisper action, then we can ignore a whisper action when searching for the latest action from another user.

App/src/libs/actions/Report.ts

Lines 1005 to 1010 in 58abe89

	const latestReportActionFromOtherUsers = Object.values(reportActions ?? {}).reduce((latest: ReportAction | null, current: ReportAction) => {
	if (current.actorAccountID !== currentUserAccountID && (!latest || current.created > latest.created)) {
	return current;
	}
	return latest;
	}, null);

(FYI, another example where a whisper message created value isn't included in lastVisibleActionCreated is a scan money request)

if (current.actorAccountID !== currentUserAccountID && (!latest || current.created > latest.created) && (current.actionName !== 'ACTIONABLEMENTIONWHISPER' && !ReportActionsUtils.isWhisperAction(current))) {
    return current;
}

this is assuming ACTIONABLEMENTIONWHISPER is the only whisper that is considered in lastVisibleActionCreated value, who knows maybe it's another BE issue

What alternative solutions did you explore? (Optional)

If lastVisibleActionCreated need to always include whisper action created, then we need to update the BE and FE optimistic value on some action.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01103e15827eecbf8f

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @akinwale (External)

[melvin-bot]

Upwork job price has been updated to $250