[HOLD for payment 2024-06-20] [$500] [Held requests] No confirmation prompt when approving held request via the report preview

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.58-4
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team

Issue found when executing PR #33124

Action Performed:

Precondition:

• Admin and employee are in the Collect workspace

1. Go to staging.new.expensify.com
2. [Employee] Request money from the workspace chat
3. [Employee] Go to transaction thread, select Hold request and hold the request
4. [Admin] Go to expense report with the employee
5. [Admin] Click Approve button
6. Note that it shows the prompt to approve the held request
7. [Admin] Return to the main workspace chat with employee
8. [Admin] Click Approve
9. Note that there is no prompt to approve the held request
10. Repeat Step 4 to 9 with Pay with Expensify button in both expense report and main chat

Expected Result:

When clicking on the approve button in expense report (Step 4) and main chat (Step 7), there will be a confirmation prompt to approve the held request

Actual Result:

When approving the held request from the main chat, there is no confirmation prompt. The same goes for Pay with Expensify button

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6433337_1711892581287.20240331_213437.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01db46b9f151c17d73
• Upwork Job ID: 1774864170413936640
• Last Price Increase: 2024-05-28
• Automatic offers:
• DylanDylann | Contributor | 102499792
• nkdengineer | Contributor | 102527527

Issue Owner

Current Issue Owner: @slafortune

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @bondydaa (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[lanitochka17]

@bondydaa FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[lanitochka17]

We think that this bug might be related to #wave-collect - Release 1

[bondydaa]

digging into this now

[bondydaa]

I think it coming from this PR #33124 but it's not immediately clear to me why, looking further.

[bondydaa]

oh i missed the exact case here, it's that clicking approve in the reportPreview doesn't trigger the model. I thought it was that when you click the same approve button twice it didn't re-trigger the confirmation model 🤦 .

[bondydaa]

I've asked for confirmation here #31345 (comment)

not sure this actually needs to be a blocker or not, this case might not have been scoped out in the original GH so it could have just been an oversight.