[HOLD for payment 2024-04-15] [$500] IOU - Opening IOU receipt leads to not here page

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.59-0
Reproducible in staging?: y
Reproducible in production?: n
Issue reported by: Applause - Internal Team

Action Performed:

1. Go to staging.new.expensify.com
2. Go to FAB > Request money.
3. Create a manual request with receipt from user that has no unsettled IOU.
4. In 1:1 DM, click on the IOU preview.
5. Click on the receipt.

Expected Result:

Receipt opens without issue.

Actual Result:

Opening IOU receipt leads to not here page

Workaround:

n/a

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6435480_1712058058413.receipt.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0170155bec83d697ff
• Upwork Job ID: 1775191991451828224
• Last Price Increase: 2024-04-02

[melvin-bot]

Triggered auto assignment to @iwiznia (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[kbecciv]

We think that this bug might be related to #wave-collect - Release 1

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[bernhardoj]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Opening the money request receipt shows not found page.

What is the root cause of that problem?

The condition to show the not found page is checking whether the report parentReportID is not the same as the transaction reportID.

App/src/pages/TransactionReceiptPage.tsx

Line 62 in a1801c8

shouldShowNotFoundPage={(report?.parentReportID ?? '') !== transaction?.reportID}

When this code is made, we can only open the receipt from the transaction thread, so report parentReportID will point to the IOU/expense report, which is the same as transaction reportID.

However, after the one transaction report view PR, we are showing the receipt and other money request fields in the IOU report, so the condition is always false because IOU report parentReportID points to the chat report.

What changes do you think we should make in order to solve the problem?

We should check whether the report is a money request report or not. If it's a money request report, we just take the reportID, otherwise take the parentReportID.

const moneyRequestReportID = ReportUtils.isMoneyRequestReport(report) ? report?.reportID : report?.parentReportID;

shouldShowNotFoundPage={(moneyRequestReportID ?? '') !== transaction?.reportID}

[shubham1206agra]

@bernhardoj Can you update your solution to cover Track Expense on selfDM?

[bernhardoj]

I don't see the problem with track expense

[shubham1206agra]

Just make a track expense with the receipt. And try to open the receipt.

[bernhardoj]

Screen.Recording.2024-04-02.at.23.40.39.mov

Works fine.

[shubham1206agra]

Oh. Looks like a BE issue, then. Please continue here.