[HOLD for payment 2024-04-15] [$500] IOU - Replace receipt option is available for requestee in combined IOU report

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.59-0
Reproducible in staging?: y
Reproducible in production?: n
Issue reported by: Applause - Internal Team

Action Performed:

1. Go to staging.new.expensify.com
2. [User A] Go to chat with User B that has no unsettled IOU.
3. [User A] Request money from User B and attach a receipt.
4. [User B] Go to combined IOU report with User A.
5. [User B] Click on the receipt.
6. [User B] Click 3-dot menu.

Expected Result:

There will be no Replace receipt option for User B (requestee).

Actual Result:

Replace receipt option is available for User B (requestee).
This issue only happens in combined IOU report.

Workaround:

n/a

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6435778_1712075771965.20240403_003243.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01e259e1fb396c9678
• Upwork Job ID: 1775695048648724480
• Last Price Increase: 2024-04-04

[melvin-bot]

Triggered auto assignment to @tylerkaraszewski (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[kbecciv]

We think that this bug might be related to #wave-collect - Release 1

[nkdengineer]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Replace receipt option is available for User B (requestee).
This issue only happens in combined IOU report.

What is the root cause of that problem?

When we open the receipt in combine report, the reportID in URL is the expense report so canEditReceipt check is wrong here because the parentReportAction now is the report preview action.

App/src/components/ReportActionItem/ReportActionItemImage.tsx

Lines 98 to 101 in 879378f

	{({report}) => (
	<PressableWithoutFocus
	style={[styles.w100, styles.h100, styles.noOutline as ViewStyle]}
	onPress={() => Navigation.navigate(ROUTES.TRANSACTION_RECEIPT.getRoute(report?.reportID ?? '', transaction?.transactionID ?? ''))}

App/src/pages/TransactionReceiptPage.tsx

Line 36 in 879378f

const canEditReceipt = ReportUtils.canEditFieldOfMoneyRequest(parentReportAction, CONST.EDIT_REQUEST_FIELD.RECEIPT);

What changes do you think we should make in order to solve the problem?

We should get the transactionReportID and pass it as reportID param of getRoute function here. So all check in TransactionReceiptPage will work well even if we open the receipt in combine report.

App/src/components/ReportActionItem/ReportActionItemImage.tsx

Lines 98 to 101 in 879378f

	{({report}) => (
	<PressableWithoutFocus
	style={[styles.w100, styles.h100, styles.noOutline as ViewStyle]}
	onPress={() => Navigation.navigate(ROUTES.TRANSACTION_RECEIPT.getRoute(report?.reportID ?? '', transaction?.transactionID ?? ''))}

To do that we should store transactionThreadReport or transactionThreadReportID in ShowContextMenuContext.

1. Add transactionThreadReport in ShowContextMenuContextProps

type ShowContextMenuContextProps = {
    ...
    transactionThreadReport: OnyxEntry<Report>;
};

const ShowContextMenuContext = createContext<ShowContextMenuContextProps>({
    ...
    transactionThreadReport: null
});

App/src/components/ShowContextMenuContext.ts

Line 12 in 879378f

type ShowContextMenuContextProps = {

2. Store transactionThreadReport into contextValue here.

App/src/pages/home/report/ReportActionItem.tsx

Line 364 in 879378f

const contextValue = useMemo(

3. Here, get transactionThreadReport and pass transactionThreadReport.reportID to getRoute function

{({report, transactionThreadReport}) => (
    <PressableWithoutFocus
        style={[styles.w100, styles.h100, styles.noOutline as ViewStyle]}
        onPress={() => Navigation.navigate(ROUTES.TRANSACTION_RECEIPT.getRoute(transactionThreadReport?.reportID ?? report?.reportID ?? '', transaction?.transactionID ?? ''))}
        accessibilityLabel={translate('accessibilityHints.viewAttachment')}
        accessibilityRole={CONST.ROLE.BUTTON}
    >
        <ReceiptImage {...propsObj} />
    </PressableWithoutFocus>
)}

App/src/components/ReportActionItem/ReportActionItemImage.tsx

Lines 98 to 101 in 879378f

	{({report}) => (
	<PressableWithoutFocus
	style={[styles.w100, styles.h100, styles.noOutline as ViewStyle]}
	onPress={() => Navigation.navigate(ROUTES.TRANSACTION_RECEIPT.getRoute(report?.reportID ?? '', transaction?.transactionID ?? ''))}

What alternative solutions did you explore? (Optional)

NA

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01e259e1fb396c9678