IOU-Comment from a deleted IOU disappears until a third IOU is created

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.59-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by:
Slack conversation:

Issue found when executing PR #36934

Action Performed:

1. Navigate to staging.new.expensify.com
2. Open workspace chat
3. Click on + icon from the compose box
4. Click on request money
5. Enter an amount and click on next
6. Enter a merchant and confirm the request
7. Repeat step 3 - 6 once again
8. Open the transaction thread for the IOU created on step 7
9. Add a comment
10. Open the transaction thread of the first IOU created at step 6
11. Click on Merchant and update it to something else
12. Go back to the expense report page and delete the second IOU created on step 7
13. Go to workspace chat page
14. Repeat step 3 - 6 once again
15. Open the expense report page

Expected Result:

The deleted IOU with the comment in thread should be present while in the expense report page

Actual Result:

The deleted IOU with the comment in thread disappears when the second IOU is deleted but re appears when a third IOU is created

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6435697_1712069986334.bandicam_2024-04-02_17-57-48-390.mp4

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @francoisl (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[francoisl]

This looks related to #36934. I can't tell if it's by design or if it was an oversight, but it's not clear to me why we're showing the [Deleted request] that have child comments. We don't show deleted as [Deleted request] if they don't have any child actions. cc @NikkiWines

[NikkiWines]

For the one-transaction view we might show it because we don't display the transaction preview for the expense (since we show a combined view) but from your screenshot this report has multiple expenses so it's a bit odd that it would show up like this.

Though i guess if you delete your expense and you had comments on it, where would we expect those comments to live? would they just disappear?

[NikkiWines]

I'm not sure if I'm doing something incorrectly but this looks the same to me on staging and production right now:

Prod

2 IOUs (1 deleted)	3 IOUs (1 deleted - middle)

Staging

2 IOUs (1 deleted)	3 IOUs (1 deleted - middle)

[francoisl]

Ok yeah that makes sense, thanks for checking. I see the same thing in production, sounds like this is something that we can polish later if we want to change the behavior. Going to demote for now.