[Awaiting Payment 23rd April] [$500] Web-Workspace -Number of announce room members does not update when remove workspace members

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.59-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4468627&group_by=cases:section_id&group_order=asc&group_id=229065
Email or phone of affected tester (no customers): applausetester+gm156@applause.expensifail.com
Issue reported by: Applause - Internal Team

Action Performed:

1. Log in as a Expensifail account
2. Create a workspace
3. Navigate to the Invite members page in workspace> Invite few accounts
4. Select the invited members and remove them
5. Send some messages in the #Announce room
6. Click on header of the room to open Details
7. Take a note of number of room members

Expected Result:

Number of announce room members should update when user remove workspace users

Actual Result:

Number of announce room members does not update when remove workspace members

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6435770_1712090667330.Recording__2786.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01758a9e58b1dd4c58
• Upwork Job ID: 1776307639554646016
• Last Price Increase: 2024-04-08

[melvin-bot]

Triggered auto assignment to @jasperhuangg (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[lanitochka17]

@jasperhuangg FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[jasperhuangg]

I can reproduce this issue, the only reason it's happening is because the DeleteMembersFromWorkspace command hasn't completed. Once it does, the number correctly updates.

I don't think this needs to be a blocker, but we should update the front-end in this case to optimistically add/remove people from a workspace's default rooms when they are added/removed from the workspace.

[melvin-bot]

Triggered auto assignment to @trjExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.