[C+ Checklist Needs Completion] [$250] Distance - Transaction thread opens after saving distance edit when there is only one request

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.59-0
Reproducible in staging?: y
Reproducible in production?: n
Issue reported by: Applause - Internal Team

Action Performed:

1. Go to staging.new.expensify.com
2. Go to workspace chat that has no unsettled request.
3. Create a distance request.
4. Click on the request preview to go to one transaction report view.
5. Click Distance.
6. Edit the distance and save it.

Expected Result:

App will stay in one transaction report view after saving the distance edit because there is only one request.

Actual Result:

Transaction thread opens after saving distance edit when there is only one request.

Workaround:

n/a

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6435985_1712086676590.20240403_033400.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01034c7477c396612a
• Upwork Job ID: 1776364222315294720
• Last Price Increase: 2024-04-05
• Automatic offers:
• paultsimura | Reviewer | 0
• bernhardoj | Contributor | 0

[melvin-bot]

Triggered auto assignment to @marcaaron (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[kbecciv]

We think that this bug might be related to #wave-collect - Release 1

[marcaaron]

I was not able to reproduce this, but ran into another bug:

A call to GetNewerActions hit a server error. Unsure if related. Checking logs...

{
  "code": 666,
  "jsonCode": 666,
  "type": "Expensify\\Libs\\Error\\ExpError",
  "UUID": "5757c554-3198-11ee-be56-0242ac120002",
  "message": "Missing reportActionID or reportID",
  "title": "",
  "data": [],
  "htmlMessage": "",
  "onyxData": [],
  "requestID": "86e4de6e880ebc79-HNL"
}

[marcaaron]

Ok, tried a second time and could not reproduce that error (worked OK).

Also can't reproduce the issue.

Expected: App will stay in one transaction report view after saving the distance edit because there is only one request.
Actual: Transaction thread opens after saving distance edit when there is only one request.

I'm not really sure what this is trying to communicate. What is a "transaction report" vs. a "transaction thread"?

I'm gonna remove the blocker and have this triaged as a normal bug.