[HOLD for payment 2024-04-15] [$500] Kill ReconnectToReport #39464
Description
In the context of optimizing ReconnectToReport, we are proposing to just get rid of it since it became redundant after reliable updates was implemented.
ReconnectToReport command was introduced to get the missing reportActions after coming back online. This was necessary because ReconnectApp didn't get reportActions, but now that we have "reliable updates", we are able to fetch and retrieve the missed Onyx updates which contain the missing report Actions (The missed updates are returned by ReconnectApp).
Version Number:
Reproducible in staging?:
Reproducible in production?:
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by:
Slack conversation:
Action Performed:
With a report open, go offline and the online again
Expected Result:
Looking at the network requests, we should only see a ReconnectApp request and not a ReconnectToReport request
Actual Result:
ReconnectToReport is there, is sometimes slow and is useless.
Workaround:
Can the user still use Expensify without this being fixed? Have you informed them of the workaround?
Platforms:
Which of our officially supported platforms is this issue occurring on?
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
Screenshots/Videos
Add any screenshot/video evidence