[HOLD for payment 2024-06-03] [$250] Room - Multiline name set for URL is shown in different format for room and task description

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.59
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by:
Slack conversation:

Action Performed:

1. Launch app
2. Tap on room chat
3. Tap on room header
4. Tap description
5. Enter s.com and save
6. Tap description again
7. Set url an multiline name and save
8. Tap plus icon --- assign task
9. Enter title
10. Enter description as s.com and save
11. Tap next and confirm task
12. Open task
13. Tap description
14. Set url an multiline name and save

Expected Result:

System message for multiline name set for URL must not be shown in different format for room and task description inconsistently.

Actual Result:

System message for multiline name set for URL is shown in different format for room and task description

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6435854_1712079389764.TX_am.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0120eebece9f86310e
• Upwork Job ID: 1775676813947215872
• Last Price Increase: 2024-04-11
• Automatic offers:
• abdulrahuman5196 | Reviewer | 0
• bernhardoj | Contributor | 0

[melvin-bot]

Triggered auto assignment to @bfitzexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[lanitochka17]

@bfitzexpensify FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[lanitochka17]

We think that this bug might be related to #vip-vsp

[bernhardoj]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The task description update message doesn't render the markdown which is different with room description.

What is the root cause of that problem?

For room description update message, the message contains a HTML of the markdown,

<muted-text>set the room description to: <a href="https://google.com" target="_blank" rel="noreferrer noopener">multi<br />line</a></muted-text>

but for task update description, even when we use markdown, the text doesn't contains the HTML representation of the MD.

updated the description to [multi
link](google.com)

So, when we try to render it, it just shows as plain text.

What changes do you think we should make in order to solve the problem?

I think we can fix it on the BE by returning the HTML representation of the MD for task description update message too, but in case we want to handle it in FE, we can do it using ExpensiMark.

App/src/components/ReportActionItem/TaskAction.tsx

Lines 17 to 22 in 7177173

	const message = TaskUtils.getTaskReportActionMessage(action);
	return (
	<View style={[styles.flex1, styles.flexRow, styles.alignItemsCenter, styles.breakWord, styles.preWrap]}>
	{message.html ? <RenderHTML html={`<muted-text>${message.html}</muted-text>`} /> : <Text style={[styles.chatItemMessage, styles.colorMuted]}>{message.text}</Text>}
	</View>

const parser = new ExpensiMark();

<RenderHTML html={`<muted-text>${parser.replace(message.html)}</muted-text>`} />

What alternative solutions did you explore? (Optional)

Convert the description to HTML optimistically and send it to the BE.
We parse the description changelog here.

App/src/libs/ReportUtils.ts

Line 4016 in aed0bf0

html: changelog,

html: getParsedComment(changelog),

The changelog can be a title or description changelog, so maybe we can conditionally parse it only when it's a description update.

And then parse the description value here that will be sent to the BE.

App/src/libs/actions/Task.ts

Line 438 in aed0bf0

const reportDescription = (description ?? report.description ?? '').trim();

const reportDescription = ReportUtils.getParsedComment((description ?? report.description ?? '').trim());

Then, we need to replace shouldParseTitle with shouldRenderAsHTML because we already parsed the description so we don't want to parse it again.

App/src/components/ReportActionItem/TaskView.tsx

Lines 141 to 144 in aed0bf0

	<MenuItemWithTopDescription
	shouldParseTitle
	description={translate('task.description')}
	title={report.description ?? ''}

We also don't need the parser.replace here anymore.

App/src/pages/tasks/TaskDescriptionPage.tsx

Line 112 in aed0bf0

defaultValue={parser.htmlToMarkdown((report && parser.replace(report?.description ?? '')) || '')}

And last, when comparing the value here on submitting,

App/src/pages/tasks/TaskDescriptionPage.tsx

Lines 47 to 52 in aed0bf0

	const submit = useCallback(
	(values: FormOnyxValues<typeof ONYXKEYS.FORMS.EDIT_TASK_FORM>) => {
	if (parser.htmlToMarkdown(parser.replace(values.description)) !== parser.htmlToMarkdown(parser.replace(report?.description ?? '')) && !isEmptyObject(report)) {
	// Set the description of the report in the store and then call EditTask API
	// to update the description of the report on the server
	Task.editTask(report, {description: values.description});

we should update it to,

if (values.description !== parser.htmlToMarkdown(report?.description ?? '') && !isEmptyObject(report)) {

No need to convert values.description to HTML and then to markdown because values.description is a markdown already.

I just realized this is what we did for the room description

App/src/libs/actions/Report.ts

Line 1754 in aed0bf0

const parsedDescription = ReportUtils.getParsedComment(newValue);

App/src/pages/RoomDescriptionPage.tsx

Line 35 in aed0bf0

const [description, setDescription] = useState(() => parser.htmlToMarkdown(report?.description ?? ''));

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0120eebece9f86310e

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @abdulrahuman5196 (External)