[On-Hold Payment 4/29] [$500] Private note - Hmm, It's Not Here' Displayed When Opening Private Note Offline After Previously Access online

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.59-3
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): abebemiherat@gmail.com
Issue reported by: Applause - Internal Team

Action Performed:

1, Navigate to any chat and click on the header
2, Open a private note
3, Make it offline
4, Click on the header again and try to open the private note
5, Observe the display of the 'Hmm, It's Not Here' page

Expected Result:

The loading indicator should appear instead of displaying the 'Hmm, It's Not Here' page.
Alternatively, the private note should be accessible offline

Actual Result:

When attempting to access the private note offline after previously accessing it online, the 'Hmm, It's Not Here' page is displayed

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6436561_1712139185110.Screen_Recording_2024-04-03_at_3.11.59_AM.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0122ad922287efa8c8
• Upwork Job ID: 1775598209564229632
• Last Price Increase: 2024-04-03
• Automatic offers:
• c3024 | Reviewer | 0
• abzokhattab | Contributor | 0

[melvin-bot]

Triggered auto assignment to @CortneyOfstad (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[lanitochka17]

We think that this bug might be related to #vip-vsp

[lanitochka17]

@CortneyOfstad FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[allgandalf]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Not here page is displayed if we access private note page offline

What is the root cause of that problem?

When we access the private notes page, we trigger WithReportAndPrivateNotesOrNotFound which checks if the result has been found or not, now you can observe that if we open a new chat for the first time and click on private notes when offline, you'll see that a loading indicator is appearing, this is because we show loading indicator based on the check:

App/src/pages/home/report/withReportAndPrivateNotesOrNotFound.tsx

Lines 73 to 75 in 7177173

	if (shouldShowFullScreenLoadingIndicator) {
	return <LoadingPage title={translate(pageTitle)} />;
	}

shouldShowFullScreenLoadingIndicator is calculated by !isPrivateNotesFetchFinished:

App/src/pages/home/report/withReportAndPrivateNotesOrNotFound.tsx

Line 38 in 7177173

const isPrivateNotesFetchTriggered = report.isLoadingPrivateNotes !== undefined;

isPrivateNotesFetchFinished is checked such that it will be true is isLoadingPrivateNotes has some value, but for the first time this value is undefined.

Now coming to the bug, when we click on private notes the first time we are online, we essentially set the value of isLoadingPrivateNotes, so this will now have some value and isPrivateNotesFetchFinished will be set to true.

Now shouldShowFullScreenLoadingIndicator is true if we do not trigger the fetch request:

App/src/pages/home/report/withReportAndPrivateNotesOrNotFound.tsx

Line 55 in 7177173

const shouldShowFullScreenLoadingIndicator = !isPrivateNotesFetchFinished;

But here as we fetched private notes when online, this will cause the value of shouldShowFullScreenLoadingIndicator to be false and hence we will see hmm, it's not here page

What changes do you think we should make in order to solve the problem?

To be consistent with the design that we will show a loading indicator when the user is offline for private notes page when he accesses it for the first time when offline, we should add a && condition to isPrivateNotesFetchFinished which also checks if the user is not offline by using isOffline check, now this check can either be triggered at 2 places:

App/src/pages/home/report/withReportAndPrivateNotesOrNotFound.tsx

Line 38 in 7177173

const isPrivateNotesFetchTriggered = report.isLoadingPrivateNotes !== undefined;

const isPrivateNotesFetchTriggered = report.isLoadingPrivateNotes !== undefined && !isOffline;

Or

App/src/pages/home/report/withReportAndPrivateNotesOrNotFound.tsx

Line 55 in 7177173

const shouldShowFullScreenLoadingIndicator = !isPrivateNotesFetchFinished;

What alternative solutions did you explore? (Optional)

N/A

[shahinyan11]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Private note - Hmm, It's Not Here' Displayed When Opening Private Note Offline After Previously Access online

What is the root cause of that problem?

Because of this implementation, shouldShowNotFoundPage will always be true when the privateNotes is empty and user is offline

What changes do you think we should make in order to solve the problem?

Update this part of code like below

const shouldShowNotFoundPage = useMemo(() => {
    // Show not found view if the report is archived, or if the note is not of current user or if report is a self DM.
    if (ReportUtils.isArchivedRoom(report) || isOtherUserNote || ReportUtils.isSelfDM(report)) {
        return true;
    }
    
    return false;
}, [report, isOtherUserNote, shouldShowFullScreenLoadingIndicator, isPrivateNotesEmpty, isReconnecting, isOffline]);

What alternative solutions did you explore? (Optional)

Change this line like below

const shouldShowFullScreenLoadingIndicator = !isPrivateNotesFetchFinished || isOffline;

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0122ad922287efa8c8

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @c3024 (External)