IOU - Comment on a deleted IOU isn't opening from the combined report view

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.59.3
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team

Issue found when executing PR #39433

Action Performed:

1. Create a manual IOU with an account you never had contact before
2. Create a second manual IOU
3. Open the first IOU
4. Add some comments
5. Delete the first IOU
6. Navigate to the combined report view
7. Click on "Replies"

Expected Result:

I should be able to view comments

Actual Result:

Comment on a deleted IOU isn't opening from the combined report view after deleting the first IOU

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6436784_1712153486741.bandicam_2024-04-03_16-02-31-958.mp4

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @tgolen (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[lanitochka17]

@tgolen FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[tgolen]

Yeah, I do think this is a bug. Before going external with it, there are a couple of suspect PRs on the deploy list which might have caused this.

@NikkiWines @bernhardoj Could this be a regression from #39419?
@srikarparsi @pac-guerreiro Could this be a regression from #35253?

[bernhardoj]

#39419 only touches the receipt attachment modal page, so it shouldn't cause this issue.

[srikarparsi]

Still checking if this has to do something with the TS migration but wanted to say that I don't think the issue is related to commenting. The expense report level page is missing in staging for reports with single expenses (this could be expected behavior but it's not the behavior in production). And that's why in this bug, clicking replies takes you directly to the transaction thread instead of the expense report.

Production (Chat -> Expense Report -> Transaction Thread):
https://github.com/Expensify/App/assets/48188732/8d0c1a07-91e4-4181-acc7-c78b2343f916

Staging (Chat -> Transaction Thread):
https://github.com/Expensify/App/assets/48188732/1b978870-a954-4508-8c53-07fa33099c4d

I'm guessing that we recently made a change to directly go to the transaction thread when clicking on a report if the report only has one expense.

I'll try looking at any other PRs that might've caused this and also try rolling back the TS migration but I don't think that it caused this.

[srikarparsi]

Ah, looks like a PR for single transaction pages does exist. @NikkiWines do you think this could be a regression from that?

[tgolen]

Thanks @srikarparsi if we can't find this one quickly, I'll make sure I can reproduce it and then use git bisect to find out exactly what broke it. I'll be able to do that in about 2 hours as I'm in a meeting currently.