[payment DUE] [$250] Don't show GBR to AM/guides for managed customer employee invitations

[joekaufmanexpensify]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Issue reported by: @joekaufmanexpensify / @greg-schroeder
Slack conversation: https://expensify.slack.com/archives/C03U7DCU4/p1709891758477419

Action Performed:

1. Expensify account manager/guide is added to customer's workspace to assist them.
2. Employee requests to join workspace.

Expected Result:

Account manager/guide should not have the workspace join request pinned to their LHN, since they are not a part of the company, and should not action it on their behalf.

Actual Result:

Account manager/guide has the workspace join request pinned to their LHN as GBR.

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01b0c3b670623a55c2
• Upwork Job ID: 1775996355860926464
• Last Price Increase: 2024-04-11
• Automatic offers:
• Pujan92 | Reviewer | 0

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01b0c3b670623a55c2

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @Pujan92 (External)

[melvin-bot]

Triggered auto assignment to @zanyrenney (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[joekaufmanexpensify]

Another proposal here is to make an explicit AM/guide an explicit workspace role. Which could be the better long term solution

[twisterdotcom]

I am a huge fan of doing whatever needs to be done to fix this quickly and for now. This is just causing super high annoyance and noise for me and every single person on our Sales and Account Management team.

[ShridharGoel]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Account manager gets report shown as having a new join request in LHN.

What is the root cause of that problem?

The current logic doesn't check if the user is an account manager before pinning and marking as unread + showing the green dot.

if (ReportActionsUtils.isActionableJoinRequestPending(report.reportID)) {
    result.isPinned = true;
    result.isUnread = true;
    result.brickRoadIndicator = CONST.BRICK_ROAD_INDICATOR_STATUS.INFO;
}

What changes do you think we should make in order to solve the problem?

We can add a check to not show as pinned, unread and green dot if the user is from Expensify team.

if (ReportActionsUtils.isActionableJoinRequestPending(report.reportID) && !PolicyUtils.isExpensifyTeam(personalDetail?.login)) {
    result.isPinned = true;
    result.isUnread = true;
    result.brickRoadIndicator = CONST.BRICK_ROAD_INDICATOR_STATUS.INFO;
}

We might also need to add another condition: if the owner is from Expensify team, then we can show as pinned, unread and with green dot for Expensify accounts also because that might mean that the workspace belongs to Expensify itself.

The above is something that needs discussion.

Code is this situation can be:

if (ReportActionsUtils.isActionableJoinRequestPending(report.reportID)) {
    if (PolicyUtils.isExpensifyTeam(personalDetail?.login) && !PolicyUtils.isExpensifyTeam(result.ownerEmail)) {
        return;
    }
    result.isPinned = true;
    result.isUnread = true;
    result.brickRoadIndicator = CONST.BRICK_ROAD_INDICATOR_STATUS.INFO;
}