[HOLD for payment 2024-05-09] [HOLD for payment 2024-05-08] HIGH: [API Reliability] [$250] Multiple calls to `OpenReport` on signin

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.60-7
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @quinthar
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1712180869292309

Action Performed:

1. Sign in to NewDot

Expected Result:

Only one OpenReport is called since I open it only once

Actual Result:

It is called twice

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0138cc8ab53b98e8c0
• Upwork Job ID: 1777757590524878848
• Last Price Increase: 2024-04-16
• Automatic offers:
• abdulrahuman5196 | Reviewer | 0
• bernhardoj | Contributor | 0

Issue Owner

Current Issue Owner: @muttmuure

[melvin-bot]

Triggered auto assignment to @muttmuure (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[bernhardoj]

Proposal

Please re-state the problem that we are trying to solve in this issue.

There are 2 duplicate OpenReport request when opening a report for the first time, for example after sign in.

What is the root cause of that problem?

The first OpenReport is called when ReportScreen is mounted (fetchReportIfNeeded).

App/src/pages/home/ReportScreen.tsx

Lines 434 to 438 in f150229

	useEffect(() => {
	Timing.end(CONST.TIMING.CHAT_RENDER);
	Performance.markEnd(CONST.TIMING.CHAT_RENDER);
	fetchReportIfNeeded();

The second OpenReport is called when ReportActionsView is also mounted (openReportIfNecessary).

App/src/pages/home/report/ReportActionsView.tsx

Lines 238 to 245 in f150229

	useEffect(() => {
	if (reportActionID) {
	return;
	}
	const interactionTask = InteractionManager.runAfterInteractions(() => {
	openReportIfNecessary();
	});

Both openReportIfNecessary and openReportIfNecessary won't call OpenReport if shouldFetchReport is false.

App/src/pages/home/report/ReportActionsView.tsx

Lines 114 to 116 in f150229

	if (!shouldFetchReport(report)) {
	return;
	}

If shouldFetchReport is true, then the difference between openReportIfNecessary and openReportIfNecessary is, fetchReportIfNeeded won't call OpenReport if the report already exists

App/src/pages/home/ReportScreen.tsx

Lines 399 to 404 in f150229

	// It is possible that we may not have the report object yet in Onyx yet e.g. we navigated to a URL for an accessible report that
	// is not stored locally yet. If report.reportID exists, then the report has been stored locally and nothing more needs to be done.
	// If it doesn't exist, then we fetch the report from the API.
	if (report.reportID && report.reportID === reportIDFromRoute && !reportMetadata?.isLoadingInitialReportActions) {
	return;
	}

but openReportIfNecessary will always call it.

App/src/pages/home/report/ReportActionsView.tsx

Lines 113 to 119 in f150229

	const openReportIfNecessary = () => {
	if (!shouldFetchReport(report)) {
	return;
	}
	Report.openReport(reportID, reportActionID);
	};

What changes do you think we should make in order to solve the problem?

First, don't call openReportIfNecessary when ReportActionsView is mounted. Then, we need to decide whether we should always call OpenReport or not when ReportScreen is mounted even when we already have the report object. I would say yes so we always get the latest report data every time we visit a chat (and also because we did this in ReportActionsView, so the behavior is unchanged).

We can do that by removing this condition.

App/src/pages/home/ReportScreen.tsx

Lines 421 to 423 in 90412ec

	if (report.reportID && report.reportID === reportIDFromRoute && !reportMetadata?.isLoadingInitialReportActions) {
	return;
	}

[melvin-bot]

@muttmuure Whoops! This issue is 2 days overdue. Let's get this updated quick!

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0138cc8ab53b98e8c0

[muttmuure]

Adding external

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @abdulrahuman5196 (External)