[Ideal Nav][$250] Wrong tooltip shown for account avatar tab

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.60-1
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @jmills
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1712260419807649

Action Performed:

1. Open app
2. Hover on account avatar at the bottom

Expected Result:

Tooltip should be "Settings"

Actual Result:

Tooltip showing as "Profile"

Workaround:

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01474575f0efe96faf
• Upwork Job ID: 1776193861064302592
• Last Price Increase: 2024-04-05

Issue Owner

Current Issue Owner: @laurenreidexpensify

[melvin-bot]

Triggered auto assignment to @laurenreidexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[Krishna2323]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Wrong tooltip shown for account avatar tab

What is the root cause of that problem?

We are using profilePage.profile for tooltip.

App/src/pages/home/sidebar/BottomTabAvatar.tsx

Line 52 in 860998b

<Tooltip text={translate('profilePage.profile')}>

What changes do you think we should make in order to solve the problem?

We should use common.settings or create a variable for Settings in profilePage object.

Result

[allgandalf]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Wrong toottip is shown for account settings

What is the root cause of that problem?

We currently show profile as tooltip:

App/src/pages/home/sidebar/BottomTabAvatar.tsx

Line 52 in 860998b

<Tooltip text={translate('profilePage.profile')}>

What changes do you think we should make in order to solve the problem?

We should instead use initialSettingsPage.accountSettings as tooltip text as it will be more meaningful IMO:

App/src/languages/en.ts

Line 922 in 3ee7004

accountSettings: 'Account Settings',

accountSettings is not used anywhere in the current codebase so i think it was actually meant to be used for the profile indicator.

What alternative solutions did you explore? (Optional)

Instead of settings we can also use account as a tooltip:

App/src/languages/en.ts

Line 923 in 3ee7004

account: 'Account',

[laurenreidexpensify]

Confirmed on v1.4.60-8

[laurenreidexpensify]

confirming internally if this is a bug or intentional - https://expensify.slack.com/archives/C036QM0SLJK/p1712312493693709

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01474575f0efe96faf

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @mollfpr (External)