[HOLD for payment 2024-04-15] [$125] Tax - App crashes when changing tax rate offline, options not clickable on web&console error

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.60-8
Reproducible in staging?: Y
Reproducible in production?: No, new feature
Found when executing PR: #33927
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal team

Action Performed:

Precondition: user is an employee of a collect policy, and tax is enabled OD

1. Open the app and log in as an employee
2. Open the workspace chat
3. Disable internet connection
4. Tap "+" > Request money > Manual
5. Enter the amount and tap next
6. Tap Show more and select a tax rate
7. Request money
8. Open the expense
9. Tap the tax and select a tax rate

Expected Result:

The tax is displayed in the tax field, and the user can select a different one.

Actual Result:

The app crashes after opening the tax rate and selecting a different one. The tax options are not responsive on the web, and there are console errors.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6438748_1712288519367.Recording__374.mp4

Bug6438748_1712288519354.IMG_6193.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~013bd787d14b4b4b3e
• Upwork Job ID: 1776216138504876032
• Last Price Increase: 2024-04-15
• Automatic offers:
• abdulrahuman5196 | Reviewer | 0
• dukenv0307 | Contributor | 0

Issue Owner

Current Issue Owner: @stephanieelliott

[melvin-bot]

Triggered auto assignment to @nkuoch (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

Triggered auto assignment to @stephanieelliott (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[izarutskaya]

@stephanieelliott I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

[izarutskaya]

We think this issue might be related to the #collect project.

[dukenv0307]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The app crashes after opening the tax rate and selecting a different one. The tax options are not responsive on the web, and there are console errors.

What is the root cause of that problem?

policy?.taxRates?.taxes[TransactionUtils.getTaxCode(oldTransaction)] can be undefined

App/src/libs/ReportUtils.ts

Line 2786 in 8fe465d

originalMessage.oldTaxRate = policy?.taxRates?.taxes[TransactionUtils.getTaxCode(oldTransaction)].value;

What changes do you think we should make in order to solve the problem?

Update this line to

        originalMessage.oldTaxRate = policy?.taxRates?.taxes[TransactionUtils.getTaxCode(oldTransaction)]?.value;

What alternative solutions did you explore? (Optional)

NA