deprecate card.isVirtual references

[grgia]

We can stop referencing card.isVirtual and instead do a check for card.nameValuePairs?.isVirtual

BE deprecation issue - https://github.com/Expensify/Expensify/issues/382554

[ShridharGoel]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Deprecate card.isVirtual references

What is the root cause of that problem?

New change

What changes do you think we should make in order to solve the problem?

Include nameValuePairs in Card.ts

Then, find usages of card.isVirtual and chnage them to card.nameValuePairs?.isVirtual

Example in CardUtils

/**
 * Finds physical card in a list of cards
 *
 * @returns a physical card object (or undefined if none is found)
 */
function findPhysicalCard(cards: Card[]) {
    return cards.find((card) => !card.nameValuePairs?.isVirtual);
}

[ShridharGoel]

@grgia Any chances of making this external?

[SzymczakJ]

Hey! I’m Jakub Szymczak from Software Mansion, an expert agency, and I’d like to work on this issue!

[grgia]

PR in review

[melvin-bot]

Unable to auto-create job on Upwork. The BZ team member should create it manually for this issue.