[$250] You" Excluded When Selecting account Email in Share-somewhere Section

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.60-6
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause internal team
Slack conversation:

Action Performed:

Prerequisite: Please use a long display name (if the default display name is used, ensure the email address is long).
1, sign in with your Gmail account > Click on FAB and select Assign task.
2, Add a title and click next.
3, Go to share somewhere and select your account email (the email used to sign in).
4, Notice that "You" is excluded.

Expected Result:

When selecting one's account email (the email used to sign in) in Share Somewhere, "You" should not be excluded.

Actual Result:

When selecting the account email (the email used to sign in) in Share somewhere, "You" is excluded if the displayed name is long.

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6438524_1712267855352.Screen_Recording_2024-04-04_at_2.55.41_PM.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~011a3106b6d163f6b3
• Upwork Job ID: 1777358786323771392
• Last Price Increase: 2024-04-08

[melvin-bot]

Triggered auto assignment to @isabelastisser (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[m-natarajan]

@isabelastisser FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

[dragnoir]

Proposal

Please re-state the problem that we are trying to solve in this issue.

"You" excluded when selecting account with long email/name in share-somewhere section

What is the root cause of that problem?

(You) is always added to the end of the name.
and is this case, it's passed here

https://github.com/dragnoir/App/blob/595bf4075988c0b64cb0db1e37694284637fbea2/src/components/MenuItem.tsx#L495-L502

So for an example as "Testing Long name for task you with more.. (you)"

When we use numberOfLines for Text, the out of frame text wish include the (You) will be hidden

What changes do you think we should make in order to solve the problem?

We need to move (You) to the beguinning of the phrase

What alternative solutions did you explore? (Optional)

[Krishna2323]

Proposal

Please re-state the problem that we are trying to solve in this issue.

"You" excluded when selecting account with long email/name in share-somewhere section

What is the root cause of that problem?

The (You) postfix is always there but due to long display name it has been cut off and ellipsis is added. This doesn't seem like a issue but there is an inconsistency, we have don't show tooltip for self dm report in share somewhere display but it is shown in assignee display. The cause of this is the lines below, we use report?.participantAccountIDs to get display names but incase of self dm it will be an empty array.

App/src/libs/actions/Task.ts

Line 771 in ce06355

const participantAccountIDs = report?.participantAccountIDs ?? [];

App/src/libs/actions/Task.ts

Line 776 in ce06355

if (ReportUtils.isChatReport(report) && ReportUtils.isDM(report) && ReportUtils.hasSingleParticipant(report)) {

App/src/libs/actions/Task.ts

Line 777 in ce06355

const participantAccountID = report?.participantAccountIDs?.[0] ?? -1;

What changes do you think we should make in order to solve the problem?

When we have a self dm report we need to use the ownerAccountID instead of participantAccountIDs.

Pseudo-Code

/**
 * Get the share destination data
 * */
function getShareDestination(reportID: string, reports: OnyxCollection<OnyxTypes.Report>, personalDetails: OnyxEntry<OnyxTypes.PersonalDetailsList>): ShareDestination {
    const report = reports?.[`report_${reportID}`] ?? null;

    const participantAccountIDs = ReportUtils.isSelfDM(report) ? [report?.ownerAccountID ?? 0] : report?.participantAccountIDs ?? [];
    const isMultipleParticipant = participantAccountIDs.length > 1;
    const displayNamesWithTooltips = ReportUtils.getDisplayNamesWithTooltips(OptionsListUtils.getPersonalDetailsForAccountIDs(participantAccountIDs, personalDetails), isMultipleParticipant);

    let subtitle = '';
    if ((ReportUtils.isChatReport(report) && ReportUtils.isDM(report) && ReportUtils.hasSingleParticipant(report)) || ReportUtils.isSelfDM(report)) {
        const participantAccountID = ReportUtils.isSelfDM(report) ? report?.ownerAccountID ?? -1 : report?.participantAccountIDs?.[0] ?? -1;

        const displayName = personalDetails?.[participantAccountID]?.displayName ?? '';
        const login = personalDetails?.[participantAccountID]?.login ?? '';
        subtitle = LocalePhoneNumber.formatPhoneNumber(login || displayName);
    } else {
        subtitle = ReportUtils.getChatRoomSubtitle(report) ?? '';
    }
    return {
        icons: ReportUtils.getIcons(report, personalDetails, Expensicons.FallbackAvatar),
        displayName: ReportUtils.getReportName(report),
        subtitle,
        displayNamesWithTooltips,
        shouldUseFullTitleToDisplay: ReportUtils.shouldUseFullTitleToDisplay(report),
    };
}

Also, we need to pass true for fourth parameter of getDisplayNamesWithTooltips to include (you) (shouldAddCurrentUserPostfix)

App/src/pages/tasks/NewTaskPage.tsx

Lines 45 to 48 in ce06355

	const assigneeTooltipDetails = ReportUtils.getDisplayNamesWithTooltips(
	OptionsListUtils.getPersonalDetailsForAccountIDs(task?.assigneeAccountID ? [task.assigneeAccountID] : [], personalDetails),
	false,
	);

App/src/libs/actions/Task.ts

Line 773 in ce06355

const displayNamesWithTooltips = ReportUtils.getDisplayNamesWithTooltips(OptionsListUtils.getPersonalDetailsForAccountIDs(participantAccountIDs, personalDetails), isMultipleParticipant);

Result

What alternative solutions did you explore? (Optional)

If we plan to remove you post fix, then we need to make several changes.

Remove you part from these and functions and update everywhere we use these functions. Also check if we have similar functions.

App/src/libs/ReportUtils.ts

Line 1689 in 1ba0795

function getDisplayNameForParticipant(accountID?: number, shouldUseShortForm = false, shouldFallbackToHidden = true, shouldAddCurrentUserPostfix = false): string {

App/src/libs/PersonalDetailsUtils.ts

Line 35 in 1ba0795

function getDisplayNameOrDefault(passedPersonalDetails?: Partial<PersonalDetails> | null, defaultValue = '', shouldFallbackToHidden = true, shouldAddCurrentUserPostfix = false): string {

[Krishna2323]

Proposal Updated

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~011a3106b6d163f6b3

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @parasharrajat (External)