[HOLD for payment 2024-05-02] [$250] Track expense - Track expense shortcut doesn't update to the correct one in offline mode

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.62-0
Reproducible in staging?: Y
Reproducible in production?: Y
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal team

Action Performed:

1. Navigate to staging.new.expensify.com
2. Track a distance expense
3. Go offline
4. Track a manual expense
5. Click on FAB and observe the shortcut
6. Go online and do step 5 again

Expected Result:

The shortcut should update to track expense (previously was "track distance").

Actual Result:

Shortcut doesn't update to the recent track action if user is offline

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6445682_1712828866766.bandicam_2024-04-11_12-41-14-620.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01a0bd1968ee14fdd2
• Upwork Job ID: 1778795114726465536
• Last Price Increase: 2024-04-12
• Automatic offers:
• ikevin127 | Reviewer | 0
• nkdengineer | Contributor | 0

Issue Owner

Current Issue Owner: @sonialiap

[melvin-bot]

Triggered auto assignment to @sonialiap (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[izarutskaya]

We think this issue might be related to the #collect project.

[nkdengineer]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Shortcut doesn't update to the recent track action if user is offline

What is the root cause of that problem?

In buildOnyxDataForTrackExpense, we don't update the optimistic data of QAB to trackExpense action. After TrackExpense API is complete, BE returns QAB data as trackExpense action. That is the reason why in offline, QAB doesn't update when we create a track expense.

App/src/libs/actions/IOU.ts

Line 808 in 91a01a7

function buildOnyxDataForTrackExpense(

What changes do you think we should make in order to solve the problem?

In buildOnyxDataForTrackExpense function, we should update optimistic data of QAB as trackExpense action

const isScanRequest = TransactionUtils.isScanRequest(transaction);
const isDistanceRequest = TransactionUtils.isDistanceRequest(transaction);
let newQuickAction: ValueOf<typeof CONST.QUICK_ACTIONS> = CONST.QUICK_ACTIONS.TRACK_MANUAL;
if (isScanRequest) {
    newQuickAction = CONST.QUICK_ACTIONS.TRACK_SCAN
} else if (isDistanceRequest) {
    newQuickAction = CONST.QUICK_ACTIONS.TRACK_DISTANCE
}
optimisticData.push({
    onyxMethod: Onyx.METHOD.SET,
    key: ONYXKEYS.NVP_QUICK_ACTION_GLOBAL_CREATE,
    value: {
        action: newQuickAction,
        chatReportID: chatReport?.reportID,
        isFirstQuickAction: isEmptyObject(quickAction),
    },
});

App/src/libs/actions/IOU.ts

Line 808 in 91a01a7

function buildOnyxDataForTrackExpense(

Actually when we click on QAB of track expense, nothing happens because we don't have any case for track expense. It's a known issue and we're handling it in another issue.

App/src/pages/home/sidebar/SidebarScreen/FloatingActionButtonAndPopover.tsx

Line 158 in 91a01a7

const navigateToQuickAction = () => {

What alternative solutions did you explore? (Optional)

NA

[allgandalf]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Shortcut for track expense doesn't update when we track any expense in offline mode

What is the root cause of that problem?

We do not set quickAction optimistically in buildOnyxDataForTrackExpense and hence when offline, the value isn't stored in onyx and not updated in Quick Action :

App/src/libs/actions/IOU.ts

Line 808 in 91a01a7

function buildOnyxDataForTrackExpense(

What changes do you think we should make in order to solve the problem?

We need to define newQuickAction in buildOnyxDataForTrackExpense which takes values based on the type of the Track Expense Request and set it accordingly optimistically in Onyx:

    let newQuickAction: ValueOf<typeof CONST.QUICK_ACTIONS> = isScanRequest ? CONST.QUICK_ACTIONS.TRACK_SCAN : CONST.QUICK_ACTIONS.TRACK_MANUAL;

    if (TransactionUtils.isDistanceRequest(transaction)) {
        newQuickAction = CONST.QUICK_ACTIONS.TRACK_DISTANCE;
    }

    optimisticData.push({
        onyxMethod: Onyx.METHOD.SET,
        key: ONYXKEYS.NVP_QUICK_ACTION_GLOBAL_CREATE,
        value: {
            action: newQuickAction,
            chatReportID: chatReport?.reportID,
            isFirstQuickAction: isEmptyObject(quickAction),
        },
    });
    

What alternative solutions did you explore? (Optional)

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01a0bd1968ee14fdd2

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @ikevin127 (External)