[HOLD for payment 2024-05-02] [$250] Group chat - No tooltip when hovering over group member name in the chat header

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.63-0
Reproducible in staging?: Y
Reproducible in production?: N
Found when executing PR : #40134
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause-Internal team

Action Performed:

1. Go to staging.new.expensify.com
2. Go to FAB > Start chat.
3. Create a group chat.
4. Hover over group member name in the header.

Expected Result:

Tooltip will display.

Actual Result:

No tooltip when hovering over group member name in the group chat header.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6453372_1713429586098.20240418_163647.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01c4e26e9f3b200297
• Upwork Job ID: 1781107500795551744
• Last Price Increase: 2024-04-18
• Automatic offers:
• s77rt | Contributor | 0
• Nodebrute | Contributor | 0

[melvin-bot]

Triggered auto assignment to @bondydaa (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

Triggered auto assignment to @zanyrenney (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[izarutskaya]

@zanyrenney I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

[izarutskaya]

We think this issue might be related to the #collect project.

[Nodebrute]

Proposal

Please re-state the problem that we are trying to solve in this issue.

No tooltip when hovering over group member name in the chat header

What is the root cause of that problem?

It's because of the shouldUseFullTitle

App/src/pages/home/HeaderView.tsx

Line 267 in 9b839f4

shouldUseFullTitle={isChatRoom || isPolicyExpenseChat || isChatThread || isTaskReport || isGroupChat}

What changes do you think we should make in order to solve the problem?

We can add below code and then use it instead of isGroupChat

 const groupChatTooltip = report?.reportName !== ''

App/src/pages/home/HeaderView.tsx

Line 267 in 9033ccb

shouldUseFullTitle={isChatRoom || isPolicyExpenseChat || isChatThread || isTaskReport || isGroupChat}

     shouldUseFullTitle={isChatRoom || isPolicyExpenseChat || isChatThread || isTaskReport || groupChatTooltip}

We have the option to rename the variable.

How is my proposal different?
My approach to this problem differs from the other person's. Their solution may not be effective in situations where group chats are created offline. Even if groups are created in online mode, the tooltip will not be instantly available.

Screen.Recording.2024-04-19.at.1.00.49.AM.mov

What alternative solutions did you explore? (Optional)

We should remove the ||isGroupChat from here

App/src/pages/home/HeaderView.tsx

Line 267 in 9b839f4

shouldUseFullTitle={isChatRoom || isPolicyExpenseChat || isChatThread || isTaskReport || isGroupChat}

Result

Screen.Recording.2024-04-18.at.7.41.59.PM.mov