[$250] Group chat - Implement offline behavior for `UpdateGroupChatMemberRole`

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.63-0
Reproducible in staging?: y
Reproducible in production?: n
Issue reported by: Applause - Internal Team

Action Performed:

1. Go to staging.new.expensify.com
2. Go to Account settings > Workspaces > any workspace.
3. Go to Members.
4. Add members if not yet.
5. Go offline.
6. Click on the member > Change the role.
7. Note that the member row is grayed out.
8. Go to FAB > Start chat > Create a group chat.
9. Click on the header > Members.
10. Go offline.
11. Click on the member > Change the role.

Expected Result:

The member row will be grayed out.

Actual Result:

The member row is not grayed out.

Workaround:

n/a

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6453397_1713431294657.20240418_170505.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~012d46118164c08a83
• Upwork Job ID: 1781053379706904576
• Last Price Increase: 2024-04-18
• Automatic offers:
• s77rt | Reviewer | 0

Issue Owner

Current Issue Owner: @bfitzexpensify

[melvin-bot]

Triggered auto assignment to @amyevans (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[kbecciv]

We think that this bug might be related to #vip-vsb

[nexarvo]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Member row is not grayed out when changing role offline

What is the root cause of that problem?

We are not setting pendingAction for participants in updateGroupChatMemberRoles function.

What changes do you think we should make in order to solve the problem?

We can add pendingAction in updateGroupChatMemberRoles like this:

accountIDList.forEach((accountID) => {
    memberRoles[accountID] = role;
-   participants[accountID] = {role}; 
+   participants[accountID] = {role, pendingAction: CONST.RED_BRICK_ROAD_PENDING_ACTION.UPDATE};
});

Finally we need to check this pending action for getUser in ReportParticpantsPage here:

-    pendingAction: pendingChatMember?.pendingAction,
+    pendingAction: pendingChatMember?.pendingAction ?? report.participants?.[accountID].pendingAction,

What alternative solutions did you explore? (Optional)

Result

7f4255b4-3802-4929-bd74-6867a1021176.mp4

[amyevans]

This is a minor issue so no need to block deploy.

I do think it's worth making consistent with the offline behavior of updating member roles on a workspace though. Do you want to work on polish items @marcaaron or should I make it external?

[marcaaron]

Yeah I agree. I can take this off your hands as well if you want since it's related to the Group Chats project.

[amyevans]

Wfm, thanks!