[$250] GRP chat - Invalid group chat name error still persists after clearing group name text

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: v1.4.63-7
Reproducible in staging?: y
Reproducible in production?: n
Issue found when executing PR: ttps://github.com/Expensify/App/pull/39757
Issue reported by: Applause - Internal Team

Action Performed:

Precondition : User [A] created group chat with group name

1. User A - Go the created group chat
2. Tap on header >> Settings option
3. Enter over 255 characters in the Name text input field & tap on Save button (Note : error message appears)
4. Remove all the text & tap on save (Note : Report name becomes a default with emails + first name in alphabetical order , but the error message still displayed)

Expected Result:

When maximum characters entered & later removing all the group name text, error message "Invalid group chat name" should be cleared as well. Only the group name with default with emails + first name in alphabetical order should be shown

Actual Result:

"Invalid group chat name" error message still displayed after clearing group name text

Workaround:

n/a

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6455003_1713538443610.Errormessagepersists.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0155d31c13ca9e9680
• Upwork Job ID: 1781375437507940352
• Last Price Increase: 2024-04-19
• Automatic offers:
• dukenv0307 | Reviewer | 0
• neonbhai | Contributor | 0

[melvin-bot]

Triggered auto assignment to @yuwenmemon (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[kbecciv]

We think that this bug might be related to #vip-vsb

[neonbhai]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Invalid group chat name error still persists after clearing group name text

What is the root cause of that problem?

We don't clear the error fields when setting new name optimistically here:

App/src/libs/actions/Report.ts

Lines 572 to 579 in 09ad468

	function updateGroupChatName(reportID: string, reportName: string) {
	const optimisticData: OnyxUpdate[] = [
	{
	onyxMethod: Onyx.METHOD.MERGE,
	key: `${ONYXKEYS.COLLECTION.REPORT}${reportID}`,
	value: {reportName},
	},
	];

What changes do you think we should make in order to solve the problem?

We should clear errorFields for reportName when setting it in optimisticData

errorFields: {
    reportName: null,
},

We do the same when updating room names here:

App/src/libs/actions/Report.ts

Lines 2030 to 2032 in 09ad468

	errorFields: {
	reportName: null,
	},