[HOLD for payment 2024-05-09] [$250] iOS - Start Chat - Offline indicator overlaps with navigation bar in Start chat list

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.63-7
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team

Action Performed:

1. Launch New Expensify app
2. Go to FAB > Start chat
3. Go offline

Expected Result:

Offline indicator will not overlap with navigation bar

Actual Result:

Offline indicator overlaps with navigation bar

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~011f820b0b52933326
• Upwork Job ID: 1781781063752663040
• Last Price Increase: 2024-04-20
• Automatic offers:
• Krishna2323 | Contributor | 0

[melvin-bot]

Triggered auto assignment to @srikarparsi (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[lanitochka17]

@srikarparsi FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[lanitochka17]

We think that this bug might be related to #vip-vsp

[lanitochka17]

Production:

[Krishna2323]

Proposal

Please re-state the problem that we are trying to solve in this issue.

iOS - Start Chat - Offline indicator overlaps with navigation bar in Start chat list

What is the root cause of that problem?

We haven't wrapped NewChatPage with ScreenWrapper component. We have ScreenWrapper in WorkspaceNewRoomPage.

App/src/pages/NewChatPage.tsx

Lines 278 to 311 in 4350e96

	return (
	<View
	style={styles.flex1}
	testID={NewChatPage.displayName}
	>
	<KeyboardAvoidingView
	style={styles.flex1}
	behavior="padding"
	// Offset is needed as KeyboardAvoidingView in nested inside of TabNavigator instead of wrapping whole screen.
	// This is because when wrapping whole screen the screen was freezing when changing Tabs.
	keyboardVerticalOffset={variables.contentHeaderHeight + (insets?.top ?? 0) + variables.tabSelectorButtonHeight + variables.tabSelectorButtonPadding}
	>
	<SelectionList<OptionsListUtils.Option & ListItem>
	ListItem={UserListItem}
	sections={areOptionsInitialized ? sections : CONST.EMPTY_ARRAY}
	textInputValue={searchTerm}
	textInputHint={isOffline ? `${translate('common.youAppearToBeOffline')} ${translate('search.resultsAreLimited')}` : ''}
	onChangeText={setSearchTerm}
	textInputLabel={translate('optionsSelector.nameEmailOrPhoneNumber')}
	headerMessage={headerMessage}
	onSelectRow={createChat}
	onConfirm={(e, option) => (selectedOptions.length > 0 ? createGroup() : createChat(option))}
	rightHandSideComponent={itemRightSideComponent}
	footerContent={footerContent}
	showLoadingPlaceholder={!areOptionsInitialized}
	shouldPreventDefaultFocusOnSelectRow={!DeviceCapabilities.canUseTouchScreen()}
	isLoadingNewOptions={!!isSearchingForReports}
	initiallyFocusedOptionKey={firstKeyForList}
	/>
	{isSmallScreenWidth && <OfflineIndicator />}
	</KeyboardAvoidingView>
	</View>
	);
	}

What changes do you think we should make in order to solve the problem?

Instead of View, we should wrap the component with ScreenWrapper like we do in WorkspaceNewRoomPage.

What alternative solutions did you explore? (Optional)

Result

[srikarparsi]

I believe this has to do with this PR. cc @Luke9389 @rushatgabhane. Is there a reason we don't use the shouldShowOfflineIndicator property in the outer NewChatSelectorPage.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~011f820b0b52933326