[HOLD for payment 2024-06-03] [$250] Playback speed is not displayed correctly in video player

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.63-7
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @blimpich / @KMichel1030
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1713565240359109

Action Performed:

1. Upload two videos(Video1, Video2).
2. Play Video1.
3. Then change playback speed to 0.25 (or any other)
4. Play Video2.
5. Check playback speed of Video2 (three dot menu -> playback speed).

Expected Result:

Playback speed of Video2 should be displayed as 1

Actual Result:

Video2 is played at speed 1 but playback speed is displayed as 0.25

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Issue.1.mp4

Recording.3004.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01648564b9cecf0115
• Upwork Job ID: 1781837388056326144
• Last Price Increase: 2024-04-24
• Automatic offers:
• hungvu193 | Contributor | 0

Issue Owner

Current Issue Owner: @stephanieelliott

[melvin-bot]

Triggered auto assignment to @stephanieelliott (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[superdev100]

Proposal

Please re-state the problem that we are trying to solve in this issue.

We have two problems in this issue
First

1. Play Video1 and change playback speed to 0.25
2. Play Video2 and change playback speed to 0.5
3. Play Video1 again and check speed

Expected Result:
Video1's speed should be 0.25
Actual result:
Video1 is actually played in speed of 0.25, but if we check speed in menu it is 0.5

Second

1. Upload 2 videos(Video1, Video2)
2. Play Video2.
3. Play Video1 and change playback speed to 0.25.
4. Change playback speed of Video2 to 2 without play.

Expected Result:
Video2's speed should be updated
Actual result:
Video1's speed is updated.

What is the root cause of that problem?

First
Playback speed is stored in currentPlaybackSpeed in VideoPopoverMenuContext. Once it is set, it shows same value for all video player components.

App/src/components/VideoPlayerContexts/VideoPopoverMenuContext.tsx

Line 18 in 8616678

const [currentPlaybackSpeed, setCurrentPlaybackSpeed] = useState<PlaybackSpeed>(CONST.VIDEO_PLAYER.PLAYBACK_SPEEDS[2]);

Second
When changing playback speed, we change speed of currentVideoPlayerRef.
currentVideoPlayerRef indicates currently playing video. So if we change playback speed of video which is not playing, playing video's speed is changed.

App/src/components/VideoPlayerContexts/VideoPopoverMenuContext.tsx

Lines 22 to 27 in 8616678

	const updatePlaybackSpeed = useCallback(
	(speed: PlaybackSpeed) => {
	setCurrentPlaybackSpeed(speed);
	currentVideoPlayerRef.current?.setStatusAsync?.({rate: speed});
	},
	[currentVideoPlayerRef],

What changes do you think we should make in order to solve the problem?

First

1. Add `setCurrentPlaybackSpeed here.
2. Add below line here
   setCurrentPlaybackSpeed: (speed: PlaybackSpeed) => void;
3. We have to get playback speed from ref and set currentPlaybackSpeed when opening three dot menu.
   get setCurrentPlaybackSpeed from useVideoPopoverMenuContext.
   const {setCurrentPlaybackSpeed} = useVideoPopoverMenuContext();
   Add below part in this function

 videoPlayerRef.current?.getStatusAsync().then((status) => {
            if (!('rate' in status && status.rate)) {
                return;
            }
            setCurrentPlaybackSpeed(status.rate as PlaybackSpeed);
        });

Second
We have to set speed of videoPlayerRef instead of currentVideoPlayerRef.

1. Add ref(playerRef) which stores current video ref(ref of video player which we are trying to change speed) in VideoPopoverMenuContext.

Add below part here
const playerRef = useRef<VideoWithOnFullScreenUpdate | null>(null);

And also add playerRef to contextValue

2. set playerRef with videoPlayerRef when opening popover menu

playerRef.current = videoPlayerRef.current;

App/src/components/VideoPlayer/BaseVideoPlayer.tsx

Lines 94 to 95 in 8616678

	const showPopoverMenu = (event?: GestureResponderEvent | KeyboardEvent) => {
	setIsPopoverVisible(true);

3. In updatePlaybackSpeed function, change speed of playerRef, not currentVideoPlayerRef.

What alternative solutions did you explore? (Optional)

If we want change currently playing video when opening popover menu:

• Add setCurrentPlaybackSpeed here.
• Add below line here
  setCurrentPlaybackSpeed: (speed: PlaybackSpeed) => void;
• Get setCurrentPlaybackSpeed from useVideoPopoverMenuContext.
  const {setCurrentPlaybackSpeed} = useVideoPopoverMenuContext();
• We should add below part here.

updateCurrentlyPlayingURL(url);
videoPlayerRef.current?.getStatusAsync().then((status) => {
          if(!('rate' in status && status.rate)) {
              return;
          }
          setCurrentPlaybackSpeed(status.rate as PlaybackSpeed);
      })

• Then to prevent auto playing when opening pop over menu.
  We have to check if popover menu is opened or not in this part.
  We have to replace this part with below part.

shareVideoPlayerElements(videoPlayerRef.current, videoPlayerElementParentRef.current, videoPlayerElementRef.current, !isUploading && !isPopoverVisible);

[melvin-bot]

📣 @KMichel1030! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

1. Make sure you've read and understood the contributing guidelines.
2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
   
   Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01648564b9cecf0115

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @ntdiary (External)

[melvin-bot]

Upwork job price has been updated to $150