[HOLD for payment 2024-05-09] [$250] Incorrect video downloaded

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.63-7
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @blimpich / @KMichel1030
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1713565550549779

Action Performed:

1. Upload two videos
2. Play video 1
3. Play video 2
4. Open three dot menu of video Some initial fixes and code style updates #1 and press Download

Expected Result:

Video #1 should be downloaded.

Actual Result:

Video #2 is downloaded.

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Recording.3005.mp4

Issue.2.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01c92de1e47026775d
• Upwork Job ID: 1781835136773414912
• Last Price Increase: 2024-04-20
• Automatic offers:
• rayane-djouah | Reviewer | 0

Issue Owner

Current Issue Owner: @kadiealexander

[melvin-bot]

Triggered auto assignment to @kadiealexander (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[superdev100]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Incorrect video downloaded

What is the root cause of that problem?

When downloading, we get source uri from currentlyPlayingURL.
currentlyPlayingURL indicates currently playing video. So if we try to download video which is not playing, playing video is downloaded.

App/src/components/VideoPlayerContexts/VideoPopoverMenuContext.tsx

Lines 30 to 36 in 8616678

	const downloadAttachment = useCallback(() => {
	if (currentlyPlayingURL === null) {
	return;
	}
	const sourceURI = addEncryptedAuthTokenToURL(currentlyPlayingURL);
	fileDownload(sourceURI);
	}, [currentlyPlayingURL]);

What changes do you think we should make in order to solve the problem?

We can get source uri from videoPlayerRef instead of currentlyPlayingURL.

1. Add ref which stores current video ref(ref of video player which we are trying to download) in VideoPopoverMenuContext
2. set ref with videoPlayerRef when opening popover menu
   

   App/src/components/VideoPlayer/BaseVideoPlayer.tsx

   Lines 94 to 95 in 8616678

   	const showPopoverMenu = (event?: GestureResponderEvent | KeyboardEvent) => {
   	setIsPopoverVisible(true);

3. In downloadAttachment function, get uri from that ref.

What alternative solutions did you explore? (Optional)

We can update currentlyPlayingURL, currentVideoPlayerRef, when opening popover menu.

App/src/components/VideoPlayer/BaseVideoPlayer.tsx

Lines 94 to 100 in 8616678

	const showPopoverMenu = (event?: GestureResponderEvent | KeyboardEvent) => {
	setIsPopoverVisible(true);
	if (!event || !('nativeEvent' in event)) {
	return;
	}
	setPopoverAnchorPosition({horizontal: event.nativeEvent.pageX, vertical: event.nativeEvent.pageY});
	};

test.mp4

[melvin-bot]

📣 @KMichel1030! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

1. Make sure you've read and understood the contributing guidelines.
2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
   
   Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01c92de1e47026775d

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @rayane-djouah (External)

[Krishna2323]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Incorrect video downloaded

What is the root cause of that problem?

We are using the url of the current playing video.

App/src/components/VideoPlayerContexts/VideoPopoverMenuContext.tsx

Line 16 in 8616678

const {currentVideoPlayerRef, currentlyPlayingURL} = usePlaybackContext();

App/src/components/VideoPlayerContexts/VideoPopoverMenuContext.tsx

Lines 34 to 35 in 8616678

	const sourceURI = addEncryptedAuthTokenToURL(currentlyPlayingURL);
	fileDownload(sourceURI);

What changes do you think we should make in order to solve the problem?

We should create a new state url in VideoPopooverMenuContext and pass the setState function through the context and in VideoPopoverMenu we should accept url from BaseVideoPlayer and whenever the popover becomes visible we will update the url state in VideoPopoverMenu .

// In VideoPopoverMenuContextProvider 
const [url, setUrl] = useState('');

const contextValue = useMemo(
    () => ({menuItems, updatePlaybackSpeed , setUrl}),
    [menuItems, updatePlaybackSpeed, setUrl],
);
    
// in VideoPopoverMenu
const {menuItems, setUrl} = useVideoPopoverMenuContext();   
 
useEffect(() => {
    if (!isPopoverVisible) {
        return;
    }
    setUrl(url);
}, [isPopoverVisible]);

// Pass url from BaseVideoPlayer
<VideoPopoverMenu
    isPopoverVisible={isPopoverVisible}
    hidePopover={hidePopoverMenu}
    anchorPosition={popoverAnchorPosition}
    url={url}
/>

Same can be done with videoRef/currentVideoPlayerRef if needed.

What alternative solutions did you explore? (Optional)