[HOLD for payment 2024-05-06] [$250] Join workspace - Unapproved workspace appears in workspace switcher

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.63-13
Reproducible in staging?: Y
Reproducible in production?: N
Found when validating PR : #37959
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal team

Action Performed:

Precondition:

• "Pre-approve join requests" for the workpace is disabled on Old Dot.

1. Go to staging.new.expensify.com
2. [User A] Go to Collect workspace settings > Profile.
3. {User A] Click Share > Copy URL.
4. [User B] Navigate to the Copy URL to accept the workspace invitation.
5. [User B] After the workspace appears in workspace list, go to Chat.
6. [User B] Open workspace switcher.

Expected Result:

The unapproved workspace will not appear for User B because the join request is not approved by the admin.

Actual Result:

The unapproved workspace appears in the workspace switcher for User B with empty name and it is selected by default.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6456045_1713639831829.bandicam_2024-04-21_02-51-38-640.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~013d9e03cd45fd3b64
• Upwork Job ID: 1782377855677820928
• Last Price Increase: 2024-04-22
• Automatic offers:
• nkdengineer | Contributor | 0

[melvin-bot]

Triggered auto assignment to @puneetlath (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Triggered auto assignment to @danieldoglas (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[izarutskaya]

@puneetlath I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

[izarutskaya]

We think this issue might be related to the #vip-vsb.

[izarutskaya]

Production

Recording.2384.mp4