[HOLD for payment 2024-05-22] Hold expense - Thread header for system message is different from the actual system message

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.67-0
Reproducible in staging?: Y
Reproducible in production?: Y
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal team

Action Performed:

1. Go to staging.new.expensify.com
2. Submit two expenses to a user.
3. Go to transaction thread of any expense.
4. Click 3-dot menu > Hold expense.
5. Enter a reason and save it.
6. Right click on the hold expense system message > Reply in thread.

Expected Result:

The thread header message will be consistent with the system message.

Actual Result:

The thread header shows "held this money request", while the system message is "held this expense".

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6464774_1714364776428.bandicam_2024-04-29_12-23-13-201.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01de18ac2a60287419
• Upwork Job ID: 1786066158847115264
• Last Price Increase: 2024-05-02

Issue Owner

Current Issue Owner: @miljakljajic

[melvin-bot]

Triggered auto assignment to @miljakljajic (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[izarutskaya]

We think this issue might be related to the #collect project.

[dragnoir]

BE issue.

[bernhardoj]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The thread header title for hold system message is different than the message.

What is the root cause of that problem?

For a thread, the header title will take the parent action message. The hold system message is "held this money request" as shown below

But when we render the hold system message, we render a custom message, that is "held this expense".

App/src/pages/home/report/ReportActionItem.tsx

Lines 584 to 589 in e0c12a5

	} else if (action.actionName === CONST.REPORT.ACTIONS.TYPE.HOLD) {
	children = <ReportActionItemBasicMessage message={translate('iou.heldExpense')} />;
	} else if (action.actionName === CONST.REPORT.ACTIONS.TYPE.HOLD_COMMENT) {
	children = <ReportActionItemBasicMessage message={action.message?.[0]?.text ?? ''} />;
	} else if (action.actionName === CONST.REPORT.ACTIONS.TYPE.UNHOLD) {
	children = <ReportActionItemBasicMessage message={translate('iou.unheldExpense')} />;

What changes do you think we should make in order to solve the problem?

We have 2 options,

First, in ReportUtils.getReportName, if it's a hold action, then we show the custom message ("held this expense").

App/src/libs/ReportUtils.ts

Lines 3057 to 3092 in e0c12a5

	if (isChatThread(report)) {
	if (!isEmptyObject(parentReportAction) && ReportActionsUtils.isTransactionThread(parentReportAction)) {
	formattedName = getTransactionReportName(parentReportAction);
	if (isArchivedRoom(report)) {
	formattedName += ` (${Localize.translateLocal('common.archived')})`;
	}
	return formattedName;
	}
	if (parentReportAction?.message?.[0]?.isDeletedParentAction) {
	return Localize.translateLocal('parentReportAction.deletedMessage');
	}
	const isAttachment = ReportActionsUtils.isReportActionAttachment(!isEmptyObject(parentReportAction) ? parentReportAction : null);
	const parentReportActionMessage = getReportActionMessage(parentReportAction, report?.parentReportID).replace(/(\r\n|\n|\r)/gm, ' ');
	if (isAttachment && parentReportActionMessage) {
	return `[${Localize.translateLocal('common.attachment')}]`;
	}
	if (
	parentReportAction?.message?.[0]?.moderationDecision?.decision === CONST.MODERATION.MODERATOR_DECISION_PENDING_HIDE ||
	parentReportAction?.message?.[0]?.moderationDecision?.decision === CONST.MODERATION.MODERATOR_DECISION_HIDDEN ||
	parentReportAction?.message?.[0]?.moderationDecision?.decision === CONST.MODERATION.MODERATOR_DECISION_PENDING_REMOVE
	) {
	return Localize.translateLocal('parentReportAction.hiddenMessage');
	}
	if (isAdminRoom(report) || isUserCreatedPolicyRoom(report)) {
	return getAdminRoomInvitedParticipants(parentReportAction, parentReportActionMessage);
	}
	if (parentReportActionMessage && isArchivedRoom(report)) {
	return `${parentReportActionMessage} (${Localize.translateLocal('common.archived')})`;
	}
	if (ReportActionsUtils.isModifiedExpenseAction(parentReportAction)) {
	return ModifiedExpenseMessage.getForReportAction(report?.reportID, parentReportAction);
	}
	return parentReportActionMessage;
	}

if (parentReportAction.actionName === CONST.REPORT.ACTIONS.TYPE.HOLD) {
    return Localize.translateLocal('iou.heldExpense')
}

OR

Show the original message of the hold action, just like what we did for HOLD_COMMENT.

App/src/pages/home/report/ReportActionItem.tsx

Lines 584 to 589 in e0c12a5

	} else if (action.actionName === CONST.REPORT.ACTIONS.TYPE.HOLD) {
	children = <ReportActionItemBasicMessage message={translate('iou.heldExpense')} />;
	} else if (action.actionName === CONST.REPORT.ACTIONS.TYPE.HOLD_COMMENT) {
	children = <ReportActionItemBasicMessage message={action.message?.[0]?.text ?? ''} />;
	} else if (action.actionName === CONST.REPORT.ACTIONS.TYPE.UNHOLD) {
	children = <ReportActionItemBasicMessage message={translate('iou.unheldExpense')} />;

Depends on the team which message to use.

we need to fix for unhold action too

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01de18ac2a60287419

[melvin-bot]

Triggered auto assignment to Contributor Plus for review of internal employee PR - @Ollyws (Internal)