[HOLD for payment 2024-05-09] [$250] Send invoice - Thread header in invoice workspace chat shows third line "Invoice"

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.68-0
Reproducible in staging?: Yes
Reproducible in production?: No (New Feature)
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause Internal Team
Slack conversation:

Action Performed:

1. Go to staging.new.expensify.com
2. Go to workspace chat.
3. Send a message.
4. Right click on the message > Reply in thread.
5. Note that the header consists of two lines.
6. Go to FAB > Send invoice.
7. Send an invoice.
8. In invoice workspace chat, send a message.
9. Right click on the message > Reply in thread.

Expected Result:

Only two lines will be shown in the thread header, which will be header and subtitle link.

Actual Result:

Three lines are shown in invoice workspace chat thread header, which are made of header, subtitle link and "Invoice" line.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6466136_1714443495921.bandicam_2024-04-30_10-14-23-466.mp4

Add any screenshot/video evidence

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0151a2dd35ff38b79a
• Upwork Job ID: 1785187433647714304
• Last Price Increase: 2024-04-30

Issue Owner

Current Issue Owner: @alexpensify

[melvin-bot]

Triggered auto assignment to @robertjchen (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

Triggered auto assignment to @alexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[m-natarajan]

We think this bug might be related to #wave-collect - Release 1

[m-natarajan]

@robertjchen FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

[Nodebrute]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Thread header in invoice workspace chat shows third line "Invoice"

What is the root cause of that problem?

That's because we check for isChatThread after isInvoiceRoom.

App/src/libs/ReportUtils.ts

Lines 3164 to 3169 in a462d58

	if (isInvoiceRoom(report)) {
	return Localize.translateLocal('workspace.common.invoices');
	}
	if (isChatThread(report)) {
	return '';
	}

What changes do you think we should make in order to solve the problem?

We should swap positions of these two checks.

App/src/libs/ReportUtils.ts

Lines 3164 to 3169 in a462d58

	if (isInvoiceRoom(report)) {
	return Localize.translateLocal('workspace.common.invoices');
	}
	if (isChatThread(report)) {
	return '';
	}

 if (isChatThread(report)) {
        return '';
    }
    if (isInvoiceRoom(report)) {
        return Localize.translateLocal('workspace.common.invoices');
    }

What alternative solutions did you explore? (Optional)

This check is used twice in the same function. We can eliminate the first instance.

App/src/libs/ReportUtils.ts

Lines 873 to 875 in a462d58

	function isInvoiceRoom(report: OnyxEntry<Report>): boolean {
	return getChatType(report) === CONST.REPORT.CHAT_TYPE.INVOICE;
	}

We also check for isInvoiceRoom here, so it's safe to remove the above block.

App/src/libs/ReportUtils.ts

Lines 3186 to 3188 in a462d58

	if (isInvoiceRoom(report)) {
	return Localize.translateLocal('workspace.common.invoices');
	}

Solution 3
Add a check to see if it's a chat thread. If it is, this function should return false.

App/src/libs/ReportUtils.ts

Lines 873 to 875 in a462d58

	function isInvoiceRoom(report: OnyxEntry<Report>): boolean {
	return getChatType(report) === CONST.REPORT.CHAT_TYPE.INVOICE;
	}